[S] Change in coreboot[master]: soc/mediatek: Add error handling for dptx_get_edid() - coreboot-gerrit

22 Nov 2022


      Attention is currently required from: Hung-Te Lin, Liju-Clr Chen.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69858 )
Change subject: soc/mediatek: Add error handling for dptx_get_edid()
......................................................................
Patch Set 2:
(1 comment)
File src/soc/mediatek/common/dp/dptx.c:
https://review.coreboot.org/c/coreboot/+/69858/comment/b2f8f065_ce3b0241 
PS2, Line 1114: dptx_get_edid
...
dptx_get_edid() return 0 as success, return -1 as failure. […]
Shouldn't this be `if (dptx_get_edid(&mtk_edp, edid))`?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/69858
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0fd672b175feb9b813c1d9ec4140e4273079ff07
Gerrit-Change-Number: 69858
Gerrit-PatchSet: 2
Gerrit-Owner: Liju-Clr Chen liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Reviewer: Hung-Te Lin hungte@chromium.org
Gerrit-Reviewer: Rex-BC Chen rex-bc.chen@mediatek.com
Gerrit-Reviewer: Yidi Lin yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu yupingso@google.com
Gerrit-Attention: Hung-Te Lin hungte@chromium.org
Gerrit-Attention: Liju-Clr Chen liju-clr.chen@mediatek.corp-partner.google.com
Gerrit-Comment-Date: Tue, 22 Nov 2022 07:38:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Liju-Clr Chen liju-clr.chen@mediatek.corp-partner.google.com
Comment-In-Reply-To: Yu-Ping Wu yupingso@google.com
Gerrit-MessageType: comment