Attention is currently required from: Nico Huber, Thomas Heijligen.
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69764 )
Change subject: libpayload: Fix compiler warnings
......................................................................
Patch Set 2:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/69764/comment/be51644f_a9665603
PS2, Line 9: drivers/serial/8250.c:75: [-Werror=unused-variable]
: Move variable declaration inside the
: `#if !CONFIG(LP_PL011_SERIAL_CONSOLE)` block
:
: drivers/udc/dwc2.c:505: [-Werror=format=]
: use `%zd` to match type `size_t`
Next time, it’d be great, if you did two commits with a commit message about the change. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id285c24cba790f181fa203f3117e5df35bed27c4
Gerrit-Change-Number: 69764
Gerrit-PatchSet: 2
Gerrit-Owner: Thomas Heijligen
src@posteo.de
Gerrit-Reviewer: Eric Lai
eric_lai@quanta.corp-partner.google.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Thomas Heijligen
src@posteo.de
Gerrit-Comment-Date: Sat, 19 Nov 2022 13:14:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Gerrit-MessageType: comment