Attention is currently required from: Tim Wawrzynczak. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59563 )
Change subject: mb/google/brya/variants/primus: update gpios for power consumption ......................................................................
Patch Set 1:
(3 comments)
File src/mainboard/google/brya/variants/primus/variant.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134088): https://review.coreboot.org/c/coreboot/+/59563/comment/3fc97912_b44a4268 PS1, Line 48: int sku = gpio_get(GPP_T2); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134088): https://review.coreboot.org/c/coreboot/+/59563/comment/39fdd958_5044bf78 PS1, Line 50: if ( sku == 1 ) space prohibited after that open parenthesis '('
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-134088): https://review.coreboot.org/c/coreboot/+/59563/comment/66744838_25ee54f9 PS1, Line 50: if ( sku == 1 ) space prohibited before that close parenthesis ')'