Kyösti Mälkki has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48786 )
Change subject: [WIP] coreboot_table: Expose VBNV offsets in lb_tables ......................................................................
[WIP] coreboot_table: Expose VBNV offsets in lb_tables
Use CONFIG(VBOOT_VBNV_CMOS) ?
Change-Id: I0c42720fdcc3b05337af692ed93a424575defd36 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/lib/coreboot_table.c 1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/48786/1
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 20421ef..873845e 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -189,10 +189,8 @@ } }
-#if CONFIG(CHROMEOS) static void lb_vbnv(struct lb_header *header) { -#if CONFIG(PC80_SYSTEM) struct lb_range *vbnv;
vbnv = (struct lb_range *)lb_new_record(header); @@ -200,9 +198,7 @@ vbnv->size = sizeof(*vbnv); vbnv->range_start = CONFIG_VBOOT_VBNV_OFFSET + 14; vbnv->range_size = VBOOT_VBNV_BLOCK_SIZE; -#endif } -#endif /* CONFIG_CHROMEOS */
__weak uint32_t board_id(void) { return UNDEFINED_STRAPPING_ID; } __weak uint32_t ram_code(void) { return UNDEFINED_STRAPPING_ID; } @@ -490,10 +486,9 @@ if (CONFIG(CHROMEOS)) lb_gpios(head);
-#if CONFIG(CHROMEOS) /* pass along VBNV offsets in CMOS */ - lb_vbnv(head); -#endif + if (CONFIG(CHROMEOS) && CONFIG(PC80_SYSTEM)) + lb_vbnv(head);
/* Pass mmc early init status */ lb_mmc_info(head);
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48786
to look at the new patch set (#3).
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor
Change-Id: I0c42720fdcc3b05337af692ed93a424575defd36 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/lib/coreboot_table.c 1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/48786/3
Hello build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/48786
to look at the new patch set (#4).
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor
Change-Id: I0c42720fdcc3b05337af692ed93a424575defd36 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com --- M src/lib/coreboot_table.c 1 file changed, 2 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/86/48786/4
Attention is currently required from: Kyösti Mälkki. Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48786 )
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
Patch Set 4: Code-Review+2
Attention is currently required from: Kyösti Mälkki. Duncan Laurie has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48786 )
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
Patch Set 4: Code-Review+2
Attention is currently required from: Kyösti Mälkki. Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48786 )
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
Patch Set 4: Code-Review+2
Kyösti Mälkki has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48786 )
Change subject: coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor ......................................................................
coreboot_table: Convert some CONFIG(CHROMEOS) preprocessor
Change-Id: I0c42720fdcc3b05337af692ed93a424575defd36 Signed-off-by: Kyösti Mälkki kyosti.malkki@gmail.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/48786 Reviewed-by: Arthur Heymans arthur@aheymans.xyz Reviewed-by: Duncan Laurie dlaurie@chromium.org Reviewed-by: Furquan Shaikh furquan@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/lib/coreboot_table.c 1 file changed, 2 insertions(+), 7 deletions(-)
Approvals: build bot (Jenkins): Verified Duncan Laurie: Looks good to me, approved Furquan Shaikh: Looks good to me, approved Arthur Heymans: Looks good to me, approved
diff --git a/src/lib/coreboot_table.c b/src/lib/coreboot_table.c index 86e0606..00d73a0 100644 --- a/src/lib/coreboot_table.c +++ b/src/lib/coreboot_table.c @@ -189,10 +189,8 @@ } }
-#if CONFIG(CHROMEOS) static void lb_vbnv(struct lb_header *header) { -#if CONFIG(PC80_SYSTEM) struct lb_range *vbnv;
vbnv = (struct lb_range *)lb_new_record(header); @@ -200,9 +198,7 @@ vbnv->size = sizeof(*vbnv); vbnv->range_start = CONFIG_VBOOT_VBNV_OFFSET + 14; vbnv->range_size = VBOOT_VBNV_BLOCK_SIZE; -#endif } -#endif /* CONFIG_CHROMEOS */
__weak uint32_t board_id(void) { return UNDEFINED_STRAPPING_ID; } __weak uint32_t ram_code(void) { return UNDEFINED_STRAPPING_ID; } @@ -490,10 +486,9 @@ if (CONFIG(CHROMEOS)) lb_gpios(head);
-#if CONFIG(CHROMEOS) /* pass along VBNV offsets in CMOS */ - lb_vbnv(head); -#endif + if (CONFIG(CHROMEOS) && CONFIG(PC80_SYSTEM)) + lb_vbnv(head);
/* Pass mmc early init status */ lb_mmc_info(head);
-
Arthur Heymans (Code Review) -
Duncan Laurie (Code Review)
-
Furquan Shaikh (Code Review)
-
Kyösti Mälkki (Code Review)