Attention is currently required from: Bill XIE.
Bill XIE has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74180 )
Change subject: nb/intel/gm45: Export EDID-reading routine as a function
......................................................................
Patch Set 2:
(1 comment)
File src/northbridge/intel/gm45/gma.c:
https://review.coreboot.org/c/coreboot/+/74180/comment/3f8d94e4_ef0a579f
PS2, Line 161: /*
: * GTT base is at a 2M offset and is 2M big. If GTT is smaller than 2M
: * cycles are simply not decoded which is fine.
: */
: pci_or_config16(dev, PCI_COMMAND, PCI_COMMAND_MASTER);
: memset(mmio + 2 * MiB, 0, 2 * MiB);
Should it be moved into gma_func0_init()?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74180
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ibdbe4d76f9b59e7ae83b60cda042c2d1c39827ca
Gerrit-Change-Number: 74180
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE
persmule@hardenedlinux.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Bill XIE
persmule@hardenedlinux.org
Gerrit-Comment-Date: Tue, 04 Apr 2023 09:57:08 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Bill XIE
persmule@hardenedlinux.org
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment