HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/31185
Change subject: superio/winbond/w83627ehg: Correct CR 0x2a comment ......................................................................
superio/winbond/w83627ehg: Correct CR 0x2a comment
Register 0x2a [Bit 1] is a PIN89, PIN90 function select for i2c
Change-Id: I9231a68ec7e9a3130a6b6975544bf89ab09cb3e6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/superio/winbond/w83627ehg/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/85/31185/1
diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index 04dda6e..736d660 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -32,7 +32,7 @@ { u8 reg8;
- /* Configure pins 91/92 as SDA/SCL (I2C bus). */ + /* Configure pins 89/90 as SDA/SCL (I2C bus). */ reg8 = pnp_read_config(dev, 0x2a); reg8 |= (1 << 1); pnp_write_config(dev, 0x2a, reg8);
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31185 )
Change subject: superio/winbond/w83627ehg: Correct CR 0x2a comment ......................................................................
Patch Set 1: Code-Review+2
Felix Held has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/31185 )
Change subject: superio/winbond/w83627ehg: Correct CR 0x2a comment ......................................................................
superio/winbond/w83627ehg: Correct CR 0x2a comment
Register 0x2a [Bit 1] is a PIN89, PIN90 function select for i2c
Change-Id: I9231a68ec7e9a3130a6b6975544bf89ab09cb3e6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/31185 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Felix Held felix-coreboot@felixheld.de --- M src/superio/winbond/w83627ehg/superio.c 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved
diff --git a/src/superio/winbond/w83627ehg/superio.c b/src/superio/winbond/w83627ehg/superio.c index 04dda6e..736d660 100644 --- a/src/superio/winbond/w83627ehg/superio.c +++ b/src/superio/winbond/w83627ehg/superio.c @@ -32,7 +32,7 @@ { u8 reg8;
- /* Configure pins 91/92 as SDA/SCL (I2C bus). */ + /* Configure pins 89/90 as SDA/SCL (I2C bus). */ reg8 = pnp_read_config(dev, 0x2a); reg8 |= (1 << 1); pnp_write_config(dev, 0x2a, reg8);