Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/39566 )
Change subject: util/inteltool: spi: add Sunrise Point config registers
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c
File util/inteltool/spi.c:
https://review.coreboot.org/c/coreboot/+/39566/6/util/inteltool/spi.c@66
PS6, Line 66: { 0x00, 4, "BIOS_SPI_DID_VID - Device ID and Vendor ID" },
: { 0x04, 4, "BIOS_SPI_STS_CMD - Status and Command" },
: { 0x08, 4, "BIOS_SPI_CC_RID - Revision ID" },
: { 0x0c, 4, "BIOS_SPI_BIST_HTYPE_LT_CLS - BIST, Header Type, Latency Timer, Cache Line Size" },
: { 0x10, 4, "BIOS_SPI_BAR0 - SPI BAR0 MMIO" },
IMHO we should dump everything to have everything when dumping to a log file for example
There are many more registers than these... we might as well print the
whole config space with your argument. We could, and just only print names
for those regs we know. But I'd still prefer to leave it to `lspci`.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/39566
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iee73be6118b7e5f0f1067ef677173c6bd776e7f9
Gerrit-Change-Number: 39566
Gerrit-PatchSet: 6
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Idwer Vollering
vidwer@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Mimoja
coreboot@mimoja.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Sat, 21 Mar 2020 14:51:20 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment