[S] Change in coreboot[master]: mb/google/herobrine: Only retrieve sku_id from EC once - coreboot-gerrit

29 Nov 2022


      Attention is currently required from: Shelley Chen.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/70162 )
Change subject: mb/google/herobrine: Only retrieve sku_id from EC once
......................................................................
Patch Set 2: Code-Review+2
(1 comment)
File src/mainboard/google/herobrine/boardid.c:
https://review.coreboot.org/c/coreboot/+/70162/comment/4288aeb7_553eefeb 
PS2, Line 28: 	printk(BIOS_INFO, "BoardID :%d - "
Can we get rid of this too?
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/70162
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia787968100baf58a41ccce0cf95ed3ec9ce1758a
Gerrit-Change-Number: 70162
Gerrit-PatchSet: 2
Gerrit-Owner: Shelley Chen shchen@google.com
Gerrit-Reviewer: Julius Werner jwerner@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Sudheer Amrabadi samrabad@codeaurora.org
Gerrit-CC: Venkat Thogaru thogaru@qualcomm.corp-partner.google.com
Gerrit-CC: mturney mturney mturney@codeaurora.org
Gerrit-Attention: Shelley Chen shchen@google.com
Gerrit-Comment-Date: Tue, 29 Nov 2022 23:13:16 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment