Attention is currently required from: Fred Reitberger, Jason Glenesk, Matt DeVillier.
Hello Fred Reitberger, Jason Glenesk, Matt DeVillier,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/80002?usp=email
to look at the new patch set (#2).
Change subject: soc/amd/*/romstage: factor out FSP-M call ......................................................................
soc/amd/*/romstage: factor out FSP-M call
Move the call into the FSP code to a file in the common AMD FSP code to isolate the FSP-specific parts of the code and a preparation to make the romstage of all non-CAR AMD SoCs common. Without isolating the call into the FSP-M code, building the common romstage would fail for genoa_poc due to fsp/api.h not being in the include path.
Signed-off-by: Felix Held felix-coreboot@felixheld.de Change-Id: I30cf1bee2ec1a507dc8e61eaf44067663e2505ae --- M src/soc/amd/cezanne/romstage.c A src/soc/amd/common/block/include/amdblocks/fsp.h M src/soc/amd/common/fsp/Makefile.inc A src/soc/amd/common/fsp/fsp_romstage.c M src/soc/amd/glinda/romstage.c M src/soc/amd/mendocino/romstage.c M src/soc/amd/phoenix/romstage.c M src/soc/amd/picasso/romstage.c 8 files changed, 29 insertions(+), 15 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/02/80002/2