Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42745 )
Change subject: soc/intel: Configure PAVP at compile-time
......................................................................
Patch Set 9: Code-Review+2
(2 comments)
Looks good, but please remove the Jasper Lake special treatment
after rebase.
https://review.coreboot.org/c/coreboot/+/42745/9//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/42745/9//COMMIT_MSG@9
PS9, Line 9: Expose configuration of Intel PAVP (Protected Audio-Video Path, a digital
Please break lines before 72 chars.
https://review.coreboot.org/c/coreboot/+/42745/9//COMMIT_MSG@14
PS9, Line 14: Also add a period at the end of Kconfig help for MMA while editing the file.
Not a good idea generally, it makes individual changes harder to track
(and to revert).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42745
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2aae741bb30e3be3c64324cd6334778bd271a903
Gerrit-Change-Number: 42745
Gerrit-PatchSet: 9
Gerrit-Owner: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Justin TerAvest
teravest@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Ronak Kanabar
ronak.kanabar@intel.com
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Thu, 08 Oct 2020 19:10:28 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment