Attention is currently required from: Lance Zhao.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51581 )
Change subject: northbridge/amd/pi/00730F01: Create DRTM ACPI table
......................................................................
Patch Set 4:
(1 comment)
File src/northbridge/amd/pi/00730F01/northbridge.c:
https://review.coreboot.org/c/coreboot/+/51581/comment/6d98d64b_ddfaefd9
PS4, Line 848: 16
8
Hmm. The tables here are 8-byte aligned, but in src/acpi/acpi.c the alignment is 16-byte for all tables.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51581
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Iccb64578153d993075cae524cdef87e74cf9f34c
Gerrit-Change-Number: 51581
Gerrit-PatchSet: 4
Gerrit-Owner: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Lance Zhao
Gerrit-Comment-Date: Fri, 07 May 2021 18:36:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Lance Zhao
Gerrit-MessageType: comment