Change in coreboot[master]: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors

[Julius Werner (Code Review)]

Attention is currently required from: Nico Huber, Martin Roth.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51551 )

Change subject: lint: checkpatch: Ignore ASSIGN_IN_IF and UNNECESSARY_ELSE errors
......................................................................

Patch Set 3:

(1 comment)

Patchset:

PS3:
> Does this affect the comments on Gerrit? If so, I wouldn't want […]

This will stop Jenkins from creating Gerrit comments to warn about these two things, yes (at least I hope it does, that's my goal with this patch).

Removing UNNECESSARY_ELSE doesn't mean you *have* to always put the else, of course, it just means it's left up to the author and reviewers. Do you really think this warning is critical in protecting us from a deluge of over-indented code? Personally I don't recall seeing a lot of that before we introduced checkpatch, nor have I seen many patches recently where authors started out that way and then changed it due to the Jenkins warning. If you think it's a big concern, could you point to some examples?

I'm just kinda tired of writing code that's perfectly fine according to our coding style and still get bothered about it by Jenkins, so I'm trying to reduce those cases. No matter how often we write "checkpatch is not authoritative" somewhere there's still always enough people who assume that it is or ask about it in reviews or otherwise create unnecessary churn (even if it's just when you don't know whether people are not giving you a +2 because they haven't reviewed the patch yet or they're implicitly waiting on you to "resolve" the spurious checkpatch comments). And the email spam also just gets annoying when you upload a lot of revisions for the same patch.

(Also, note that checkpatch already has a separate DEEP_INDENTATION warning for 6+ tabs if that's the primary concern here.)