Attention is currently required from: Hung-Te Lin, Paul Menzel, Yu-Ping Wu.
Vince Liu has posted comments on this change by Vince Liu. ( https://review.coreboot.org/c/coreboot/+/87021?usp=email )
Change subject: soc/mediatek/mt8189: Add USB host support
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/87021/comment/d70778ed_bcb0486c?usp... :
PS1, Line 9: Add usb host function support.
Please elaborate, what needs to be done for it.
Done
File src/soc/mediatek/mt8189/include/soc/addressmap.h:
https://review.coreboot.org/c/coreboot/+/87021/comment/532f0c1c_fdc88d2a?usp... :
PS1, Line 35: SSUSB_SIF_BASE = IO_PHYS + 0x01B00300,
Please note in the commit message, why these values were changed.
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/87021?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I5f1b4b3eb178cb9a110b97a2763c8cff5cdf0ddd
Gerrit-Change-Number: 87021
Gerrit-PatchSet: 2
Gerrit-Owner: Vince Liu
vince-wl.liu@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Liu Liu
ot_liu.liu@mediatek.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Mon, 31 Mar 2025 07:28:58 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org