Change in coreboot[master]: amdfwtool: Add ISH header support for A/B recovery layout - coreboot-gerrit

11 Nov 2021


      Attention is currently required from: Bao Zheng, Jason Glenesk, Martin Roth, Marshall Dawson, Zheng Bao.
Felix Held has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/57747 )
Change subject: amdfwtool: Add ISH header support for A/B recovery layout
......................................................................
Patch Set 24:
(1 comment)
File util/amdfwtool/amdfwtool.c:
https://review.coreboot.org/c/coreboot/+/57747/comment/b7287721_4b8279b8 
PS24, Line 751: 4096
not directly related to this patch, but it would also be good to use ERASE_ALIGNMENT or TABLE_ALIGNMENT here instead of the constant. there is at least one more instance 4 lines below; haven't checked the rest of the file
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/57747
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib0690cde1dce949514c7aacebe13096b7814ceff
Gerrit-Change-Number: 57747
Gerrit-PatchSet: 24
Gerrit-Owner: Bao Zheng fishbaozi@gmail.com
Gerrit-Reviewer: Felix Held felix-coreboot@felixheld.de
Gerrit-Reviewer: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Reviewer: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Reviewer: Martin Roth martinroth@google.com
Gerrit-Reviewer: Zheng Bao
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Bao Zheng zheng.bao@amd.corp-partner.google.com
Gerrit-CC: Paul Menzel paulepanter@mailbox.org
Gerrit-Attention: Bao Zheng fishbaozi@gmail.com
Gerrit-Attention: Jason Glenesk jason.glenesk@gmail.com
Gerrit-Attention: Martin Roth martinroth@google.com
Gerrit-Attention: Marshall Dawson marshalldawson3rd@gmail.com
Gerrit-Attention: Zheng Bao
Gerrit-Comment-Date: Thu, 11 Nov 2021 17:49:47 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment