Attention is currently required from: Maciej Pijanowski, Christian Walter, Julius Werner, Krystian Hebel, Sergii Dmytruk.
Michał Żygowski has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68747 )
Change subject: security/tpm: add TPM log format as per 1.2 spec
......................................................................
Patch Set 6:
(2 comments)
File src/commonlib/include/commonlib/tpm_log_defs.h:
https://review.coreboot.org/c/coreboot/+/68747/comment/7aa2aaa4_67025f1c
PS5, Line 1: /* SPDX-License-Identifier: GPL-2.0-only */
It's partially based on a commit by Michał Żygowski, so asked him. […]
It even should be moved to bsd includes. Let's do it.
File src/security/tpm/Kconfig:
https://review.coreboot.org/c/coreboot/+/68747/comment/00d039d0_e812707b
PS5, Line 108: bool "TPM 1.2 format"
I don't think such usage is forbidden.
Isn't TPM2.0 using only crypto agile format??
--
To view, visit
https://review.coreboot.org/c/coreboot/+/68747
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I89720615a75573d44dd0a39ad3d7faa78f125843
Gerrit-Change-Number: 68747
Gerrit-PatchSet: 6
Gerrit-Owner: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Reviewer: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Reviewer: Michał Żygowski
michal.zygowski@3mdeb.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maciej Pijanowski
maciej.pijanowski@3mdeb.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Krystian Hebel
krystian.hebel@3mdeb.com
Gerrit-Attention: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-Comment-Date: Thu, 17 Nov 2022 09:30:30 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Sergii Dmytruk
sergii.dmytruk@3mdeb.com
Gerrit-MessageType: comment