Attention is currently required from: Raul Rangel, Furquan Shaikh, Marshall Dawson, Julius Werner, Angel Pons. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/55856 )
Change subject: commonlib/region: Add support for asynchronous readat ......................................................................
Patch Set 3:
(8 comments)
File src/commonlib/include/commonlib/region.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/fe4374c9_4444f094 PS3, Line 74: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/2ce128b6_ddbdde25 PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, line over 96 characters
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/ef3cfd8e_6c1c7699 PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'const struct region_device *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/a2b33135_fafece22 PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'struct rdev_readat_async_context *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/07982e21_4795cdb5 PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'void *' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/a5473a90_cc31bc4e PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'size_t' should also have an identifier name
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/15c67187_b0f3d0e9 PS3, Line 97: cb_err_t (*readat_async)(const struct region_device *, struct rdev_readat_async_context *, void *, function definition argument 'size_t' should also have an identifier name
File src/commonlib/region.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-123302): https://review.coreboot.org/c/coreboot/+/55856/comment/5b6e126a_3f0ce873 PS3, Line 136: cb_err_t rdev_readat_async(const struct region_device *rd, struct rdev_readat_async_context *context, line over 96 characters
-
build bot (Jenkins) (Code Review)