Attention is currently required from: Dinesh Gehlot, Eric Lai, Jayvik Desai, Kapil Porwal, Nick Vaccaro, Subrata Banik.
SH Kim has posted comments on this change by SH Kim. ( https://review.coreboot.org/c/coreboot/+/86373?usp=email )
Change subject: mb/google/nissa: Create meliks variant
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS6:
It seems the VBT is requried for the coreboot build, where builder get the VBT file? […]
Jenkins was able to build on Patchset 2, but nothing special different on Patchset 6 from Patchset 2.
```
select DRIVERS_INTEL_MIPI_CAMERA
select DRIVERS_I2C_DA7219
select INTEL_GMA_HAVE_VBT
select SOC_INTEL_TWINLAKE
```
```
default 0x0 if BOARD_GOOGLE_MELIKS
```
```
default 13 if BOARD_GOOGLE_MELIKS
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86373?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iff5e27ef06a44976c2724751de0f9c6d5cf6eaaf
Gerrit-Change-Number: 86373
Gerrit-PatchSet: 6
Gerrit-Owner: SH Kim
sh_.kim@samsung.corp-partner.google.com
Gerrit-Reviewer: Dinesh Gehlot
digehlot@google.com
Gerrit-Reviewer: Eric Lai
ericllai@google.com
Gerrit-Reviewer: Jayvik Desai
jayvik@google.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jayvik Desai
jayvik@google.com
Gerrit-Attention: Eric Lai
ericllai@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Attention: Dinesh Gehlot
digehlot@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Comment-Date: Mon, 17 Feb 2025 04:29:32 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: SH Kim
sh_.kim@samsung.corp-partner.google.com