Attention is currently required from: Intel coreboot Reviewers, Julius Werner, Jérémy Compostella, Karthik Ramasubramanian.
Subrata Banik has posted comments on this change by Subrata Banik. ( https://review.coreboot.org/c/coreboot/+/86336?usp=email )
Change subject: soc/intel/cmn/pmc: Add support for early power off
......................................................................
Patch Set 3:
(1 comment)
Patchset:
PS3:
Please hold review in this CL as I will refactor this CL
1. keep only __weak here
```
/* Perform platform specific override to add support for early power off */
__weak void platform_do_early_poweroff(void)
{
printk(BIOS_EMERG, "This platform doesn't know how to power off before ramstage,"
" hanging!\n");
halt();
}
```
2. Implement the override within the respective SoC reset.c file. This will allow us to get rid of the generic overrides (if any) when Intel implements the early shutdown feature in the future (WCL) SoC.
for now, I will implement the override for RPL and PTL inside their reset.c file
--
To view, visit
https://review.coreboot.org/c/coreboot/+/86336?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I39f516640b3f75ab4c6a09826922289c0533f79b
Gerrit-Change-Number: 86336
Gerrit-PatchSet: 3
Gerrit-Owner: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Intel coreboot Reviewers
intel_coreboot_reviewers@intel.com
Gerrit-Attention: Jérémy Compostella
jeremy.compostella@intel.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Mon, 10 Feb 2025 18:18:19 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No