Change in ...coreboot[master]: (drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support

[Frans Hendriks (Code Review)]

Frans Hendriks has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29662 )

Change subject: (drivers,soc/intel/braswell}: Add C_ENVIRONMENT_BOOTBLOCK support
......................................................................

Patch Set 12:

(2 comments)

https://review.coreboot.org/#/c/29662/9/src/soc/intel/braswell/bootblock/boo... 
File src/soc/intel/braswell/bootblock/bootblock.c:

https://review.coreboot.org/#/c/29662/9/src/soc/intel/braswell/bootblock/boo... 
PS9, Line 76:
> See how it is done in src/cpu/intel/car/non-evict/cache_as_ram. […]

I dont understand your comment. This file is not used in latest patch. 
file soc/intel/braswell/bootblock/cache_as_ram.S calls FSP TempRamInit API. The FSP API will handle microcode update.
Do you want to handle microcode update at another place also?

https://review.coreboot.org/#/c/29662/11/src/soc/intel/braswell/bootblock/ca... 
File src/soc/intel/braswell/bootblock/cache_as_ram.S:

https://review.coreboot.org/#/c/29662/11/src/soc/intel/braswell/bootblock/ca... 
PS11, Line 12: either version 2 of the License, or
             :  * (at your option) any later version.
> Have you asked the previous copyright owners if they want to change the license?

Have copied this notice from other file which I assumed is the standard. Will revert this change.