Attention is currently required from: Tarun Tuli, Subrata Banik, Scott Chao, Zhuohao Lee.
Elyes Haouas has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/73173 )
Change subject: soc/intel/alderlake: Add UWES ASL into xhci.asl
......................................................................
Patch Set 6:
(3 comments)
File src/soc/intel/alderlake/acpi/xhci.asl:
https://review.coreboot.org/c/coreboot/+/73173/comment/88b71cb9_83a2fee1
PS6, Line 33: Local0 = Local0 & RO_BITS_OFF_MASK
Maybe `Local0 &= RO_BITS_OFF_MASK`
it's up to you.
https://review.coreboot.org/c/coreboot/+/73173/comment/b42f100e_e50ea04e
PS6, Line 35: Local0 = Local0 | WAKE_ON_CONNECT_DISCONNECT_ENABLE
maybe
`Local0 |= WAKE_ON_CONNECT_DISCONNECT_ENABLE`
https://review.coreboot.org/c/coreboot/+/73173/comment/e8b6d088_e0e922b1
PS6, Line 59: Local0 = Local0 & (Local0 - 1)
maybe:
`Local0 &= (Local0 - 1)`
--
To view, visit
https://review.coreboot.org/c/coreboot/+/73173
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Icbc427a89413f5fe3a4a533135cc2c39349a9580
Gerrit-Change-Number: 73173
Gerrit-PatchSet: 6
Gerrit-Owner: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Casper Chang
casper_chang@wistron.corp-partner.google.com
Gerrit-CC: Elyes Haouas
ehaouas@noos.fr
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Scott Chao
scott_chao@wistron.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Tue, 21 Feb 2023 10:21:06 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment