HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/34536 )
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded
This clean my .config from this symbol.
Change-Id: I2a17db711f615d388dbd964f67ff2cc7875c54fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/intel/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/34536/1
diff --git a/src/vendorcode/intel/Kconfig b/src/vendorcode/intel/Kconfig index 7b50995..d4f53e5 100644 --- a/src/vendorcode/intel/Kconfig +++ b/src/vendorcode/intel/Kconfig @@ -28,6 +28,7 @@ config UDK_2017_BINDING def_bool n
+if (UEFI_2_4_BINDING || UDK_2015_BINDING || UDK_2017_BINDING) config UDK_2013_VERSION int default 2013 @@ -47,3 +48,4 @@ default UDK_2013_VERSION help UEFI Development Kit version for Platform +endif
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34536 )
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
Patch Set 1: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/34536/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34536/1//COMMIT_MSG@9 PS1, Line 9: clean cleans
https://review.coreboot.org/c/coreboot/+/34536/1/src/vendorcode/intel/Kconfi... File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/34536/1/src/vendorcode/intel/Kconfi... PS1, Line 51: endif Add a comment for what sympols this is.
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34536
to look at the new patch set (#2).
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded
This clean my .config from this symbol.
Change-Id: I2a17db711f615d388dbd964f67ff2cc7875c54fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/intel/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/34536/2
Hello Patrick Rudolph, Paul Menzel, build bot (Jenkins),
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/34536
to look at the new patch set (#3).
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded
This cleans .config from unused UDK_VERSION's symbol.
Change-Id: I2a17db711f615d388dbd964f67ff2cc7875c54fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/vendorcode/intel/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/36/34536/3
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34536 )
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
Patch Set 4: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/34536/4/src/vendorcode/intel/Kconfi... File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/34536/4/src/vendorcode/intel/Kconfi... PS4, Line 23: def_bool n If these were just `bool`, they wouldn't show up either.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34536 )
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
Patch Set 4:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34536/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34536/1//COMMIT_MSG@9 PS1, Line 9: clean
cleans
Done
https://review.coreboot.org/c/coreboot/+/34536/1/src/vendorcode/intel/Kconfi... File src/vendorcode/intel/Kconfig:
https://review.coreboot.org/c/coreboot/+/34536/1/src/vendorcode/intel/Kconfi... PS1, Line 51: endif
Add a comment for what sympols this is.
Done
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/34536 )
Change subject: vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded ......................................................................
vendorcode/intel/Kconfig: Hide UDK_VERSION when unneeded
This cleans .config from unused UDK_VERSION's symbol.
Change-Id: I2a17db711f615d388dbd964f67ff2cc7875c54fb Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/34536 Reviewed-by: Nico Huber nico.h@gmx.de Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/vendorcode/intel/Kconfig 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved
diff --git a/src/vendorcode/intel/Kconfig b/src/vendorcode/intel/Kconfig index 7b50995..f341cfd 100644 --- a/src/vendorcode/intel/Kconfig +++ b/src/vendorcode/intel/Kconfig @@ -28,6 +28,7 @@ config UDK_2017_BINDING def_bool n
+if (UEFI_2_4_BINDING || UDK_2015_BINDING || UDK_2017_BINDING) config UDK_2013_VERSION int default 2013 @@ -47,3 +48,4 @@ default UDK_2013_VERSION help UEFI Development Kit version for Platform +endif # {UEFI,UDK}_BINDING
-
HAOUAS Elyes (Code Review) -
Nico Huber (Code Review)
-
Paul Menzel (Code Review)