Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34085 )
Change subject: soc/intel/icelake: Refer to soc/soc_chip.h rather than chip.h ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/34085/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/34085/2//COMMIT_MSG@7 PS2, Line 7: rather
rather *than*
Done
https://review.coreboot.org/c/coreboot/+/34085/2/src/soc/intel/icelake/acpi.... File src/soc/intel/icelake/acpi.c:
https://review.coreboot.org/c/coreboot/+/34085/2/src/soc/intel/icelake/acpi.... PS2, Line 33: #include <soc/soc_chip.h>
Please move these includes so that they are alphabetically ordered
Done