Change in ...coreboot[master]: payloads/external/Memtest86Plus: update to version 002 stable

List overview All Threads
Download

newer

older

Change in ...coreboot[master]:...

Change in coreboot[master]:...

Martin Kepplinger (Code Review)

6 May 2019 6 May '19

7:05 a.m.

Martin Kepplinger has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32613

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

payloads/external/Memtest86Plus: update to version 002 stable

The memtest86plus project has been tagged as stable. Update the coreboot build accordingly.

Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Signed-off-by: Martin Kepplinger martink@posteo.de --- M payloads/external/Memtest86Plus/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/13/32613/1

diff --git a/payloads/external/Memtest86Plus/Makefile b/payloads/external/Memtest86Plus/Makefile index 4b3132d..b799f9e 100644 --- a/payloads/external/Memtest86Plus/Makefile +++ b/payloads/external/Memtest86Plus/Makefile @@ -15,7 +15,7 @@

TAG-$(CONFIG_MEMTEST_MASTER)=origin/master NAME-$(CONFIG_MEMTEST_MASTER)=Master -TAG-$(CONFIG_MEMTEST_STABLE)=3754fd440f4009b62244e0f95c56bbb12c2fffcb +TAG-$(CONFIG_MEMTEST_STABLE)=0bd34c22604660e4283316331f3e7bf8a3863753 NAME-$(CONFIG_MEMTEST_STABLE)=Stable TAG-$(CONFIG_MEMTEST_REVISION)=$(CONFIG_MEMTEST_REVISION_ID)

Attachments:

attachment.htm (text/html — 2.6 KB)

Show replies by date

Paul Menzel (Code Review)

6 May 6 May

3:49 p.m.

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 06 May 2019 15:49:29 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Kepplinger (Code Review)

24 Jun 24 Jun

7:29 a.m.

Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

Patch Set 1:

any objections here? if they tag, we should follow, shouldn't we?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 24 Jun 2019 07:29:46 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: No Gerrit-MessageType: comment

HAOUAS Elyes (Code Review)

7:50 a.m.

HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

Patch Set 1: Code-Review+1

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Mon, 24 Jun 2019 07:50:53 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

7 Jul 7 Jul

12:09 a.m.

New subject: Change in coreboot[master]: payloads/external/Memtest86Plus: update to version 002 stable

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

Patch Set 1: Code-Review+2

(1 comment)

...

any objections here? if they tag, we should follow, shouldn't we?

I guess them is us ;) but that tag comment doesn't say anything about `stable`. Maybe wait if Martin (R.) has something to say about it.

https://review.coreboot.org/c/coreboot/+/32613/1/payloads/external/Memtest86... File payloads/external/Memtest86Plus/Makefile:

https://review.coreboot.org/c/coreboot/+/32613/1/payloads/external/Memtest86... PS1, Line 18: TAG-$(CONFIG_MEMTEST_STABLE)=0bd34c22604660e4283316331f3e7bf8a3863753 why not make it obvious and write `v002`?

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 07 Jul 2019 00:09:07 +0000 Gerrit-HasComments: Yes Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Martin Roth (Code Review)

7:51 p.m.

New subject: Change in coreboot[master]: payloads/external/Memtest86Plus: update to version 002 stable

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

Patch Set 1: Code-Review+2

Sorry, I should have done this when I made the tag.

The commit actually does say stable, even if the tag doesn't: https://review.coreboot.org/c/memtest86plus/+/29185

I'm good with Nico's comment of using the tag instead of the commit ID, but the hash doesn't bother me either.

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 1 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-Comment-Date: Sun, 07 Jul 2019 19:51:49 +0000 Gerrit-HasComments: No Gerrit-Has-Labels: Yes Gerrit-MessageType: comment

Nico Huber (Code Review)

8 Jul 8 Jul

7:54 a.m.

New subject: Change in coreboot[master]: payloads/external/Memtest86Plus: update to version 002 stable

Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32613 )

Change subject: payloads/external/Memtest86Plus: update to version 002 stable ......................................................................

payloads/external/Memtest86Plus: update to version 002 stable

The memtest86plus project has been tagged as stable. Update the coreboot build accordingly.

Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Signed-off-by: Martin Kepplinger martink@posteo.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/32613 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Paul Menzel paulepanter@users.sourceforge.net Reviewed-by: HAOUAS Elyes ehaouas@noos.fr Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Martin Roth martinroth@google.com --- M payloads/external/Memtest86Plus/Makefile 1 file changed, 1 insertion(+), 1 deletion(-)

Approvals: build bot (Jenkins): Verified Martin Roth: Looks good to me, approved Nico Huber: Looks good to me, approved Paul Menzel: Looks good to me, but someone else must approve HAOUAS Elyes: Looks good to me, but someone else must approve

-- To view, visit https://review.coreboot.org/c/coreboot/+/32613 To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings Gerrit-Project: coreboot Gerrit-Branch: master Gerrit-Change-Id: I078ac5d91e60a424efb5e14f39ae59e7ae9cbfe2 Gerrit-Change-Number: 32613 Gerrit-PatchSet: 2 Gerrit-Owner: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz Gerrit-Reviewer: HAOUAS Elyes ehaouas@noos.fr Gerrit-Reviewer: Martin Kepplinger martink@posteo.de Gerrit-Reviewer: Martin Roth martinroth@google.com Gerrit-Reviewer: Nico Huber nico.h@gmx.de Gerrit-Reviewer: Patrick Georgi pgeorgi@google.com Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net Gerrit-Reviewer: Philipp Deppenwiese zaolin.daisuki@gmail.com Gerrit-Reviewer: Werner Zeh werner.zeh@siemens.com Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org Gerrit-MessageType: merged

1776

days inactive

1839

days old

coreboot-gerrit@coreboot.org

6 comments

5 participants

tags (0)

participants (5)

HAOUAS Elyes (Code Review)
Martin Kepplinger (Code Review)
Martin Roth (Code Review)
Nico Huber (Code Review)
Paul Menzel (Code Review)