Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45951 )
Change subject: soc/intel: deduplicate ACPI timer emulation ......................................................................
Patch Set 22:
(8 comments)
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/alderlake/cp... File src/soc/intel/alderlake/cpu.c:
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/alderlake/cp... PS22, Line 26: #include <soc/pm.h> Probably not needed anymore, please also check other files.
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... File src/soc/intel/common/block/cpu/pm_timer_emulation.c:
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 3: #include <cpu/x86/msr.h> Ack
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 4: #include <intelblocks/cpulib.h> Ack
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 5: #include <intelblocks/msr.h> Ack
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 6: #include <soc/cpu.h> Nak
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 7: #include <soc/iomap.h> Ack
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 8: #include <soc/pm.h> Ack
https://review.coreboot.org/c/coreboot/+/45951/22/src/soc/intel/common/block... PS22, Line 9: #include <types.h> Nak
-
Nico Huber (Code Review)