Attention is currently required from: Arthur Heymans, Karthik Ramasubramanian, Krishna P Bhat D, Nick Vaccaro, Paul Menzel, Poornima Tom, Subrata Banik, Vamshi Krishna Gopal.
Vamshi Krishna Gopal has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/79415?usp=email )
Change subject: mb/intel/adlrvp: Add Realtek ALC256 audio verb table
......................................................................
Patch Set 7:
(1 comment)
Patchset:
PS7:
Good Suggestion Subrata, Yes ALC256 verb table is generic. Verb table can be design agnostic. […]
Subrata, I just relooked into the other designs where we are using verb table, (eg: src/mainboard/starlabs/starbook/variants/tgl/hda_verb.c) , Verb table holds register values for multiple audio endpoint and for chrome designs these values are same most of the time but in few rare cases where we need some tunning or we dont want custom set of endpoints wrt design needs, we wont be able to change them if we have verb table as generic, so i was thinking
we can have 2 options here,
1. If the current design audio endpoints aligns with generic verb table we can use generic verbtable.
2. If the current design audio endpoints doesnt align with generic verb table we can have custome verbtable specific to that design.
Let me know your thoughts.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/79415?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I8215e445dae4760ad15f69860968013e88a77af0
Gerrit-Change-Number: 79415
Gerrit-PatchSet: 7
Gerrit-Owner: Poornima Tom
poornima.tom@intel.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Reviewer: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Shelley Chen
shchen@google.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Reviewer: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.corp-partner.google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Poornima Tom
poornima.tom@intel.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Krishna P Bhat D
krishna.p.bhat.d@intel.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@google.com
Gerrit-Attention: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.com
Gerrit-Attention: Karthik Ramasubramanian
kramasub@google.com
Gerrit-Comment-Date: Thu, 18 Jan 2024 08:50:42 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Vamshi Krishna Gopal
vamshi.krishna.gopal@intel.corp-partner.google.com
Gerrit-MessageType: comment