Change in coreboot[master]: rockchip/rk3399: add the delay time between saradc power up and start...
Julius Werner has posted comments on this change. ( https://review.coreboot.org/23515 )
Change subject: rockchip/rk3399: add the delay time between saradc power up and start command ......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c File src/soc/rockchip/rk3399/saradc.c:
https://review.coreboot.org/#/c/23515/1/src/soc/rockchip/rk3399/saradc.c@74 PS1, Line 74: udelay(SARADC_DELAY_PU);
i will modify it to 4M and do the test again.
Please test multiple combinations (e.g. 4MHz 2 samples, 8MHz 4 samples, etc.) and also try to find a better understanding about the nature of the problem with your hardware engineers, so we can prove whether a certain way of sampling should work or not. In particular, please try to clarify if both delaying for more than two samples *and* reducing the sample frequency is equally necessary to resolve the problem... if only one of them helps, we don't need to waste boot time on the other.
-
Julius Werner (Code Review)