Change in ...coreboot[master]: cbfstool: show "preserved" flag in cbfstool layout output

[Patrick Georgi (Code Review)]

Patrick Georgi has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/33604

Change subject: cbfstool: show "preserved" flag in cbfstool layout output
......................................................................

cbfstool: show "preserved" flag in cbfstool layout output

The flag is useful for updaters to determine which areas to leave
alone, such as VPD (vital product data) regions that are set in
factory and might contain unique (MAC addresses) or hard to obtain
(calibration output) data.

It's also useful to see which regions are marked as such.

Change-Id: Ic0a229d474b32ac156cfabc917714ce9d339bac6
Signed-off-by: Patrick Georgi 
---
M util/cbfstool/cbfstool.c
1 file changed, 2 insertions(+), 0 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/04/33604/1

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index e8b1f6f..8fd13b5 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -1047,6 +1047,8 @@
    		qualifier = "read-only, ";
    	else if (region_is_modern_cbfs((const char *)current->name))
    		qualifier = "CBFS, ";
+		else if (current->flags & FMAP_AREA_PRESERVE)
+			qualifier = "preserve, ";
    	printf(" (%ssize %u, offset %u)\n", qualifier, current->size,
    			current->offset);

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33604 )

Change subject: cbfstool: show "preserved" flag in cbfstool layout output
......................................................................

Patch Set 1: Code-Review+1

[Martin Roth (Code Review)]

Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33604 )

Change subject: cbfstool: show "preserved" flag in cbfstool layout output
......................................................................

Patch Set 1: Code-Review+2

[Patrick Georgi (Code Review)]

Patrick Georgi has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/33604 )

Change subject: cbfstool: show "preserved" flag in cbfstool layout output
......................................................................

cbfstool: show "preserved" flag in cbfstool layout output

The flag is useful for updaters to determine which areas to leave
alone, such as VPD (vital product data) regions that are set in
factory and might contain unique (MAC addresses) or hard to obtain
(calibration output) data.

It's also useful to see which regions are marked as such.

Change-Id: Ic0a229d474b32ac156cfabc917714ce9d339bac6
Signed-off-by: Patrick Georgi 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/33604
Tested-by: build bot (Jenkins) 
Reviewed-by: Paul Menzel 
Reviewed-by: Martin Roth 
---
M util/cbfstool/cbfstool.c
1 file changed, 2 insertions(+), 0 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Martin Roth: Looks good to me, approved
  Paul Menzel: Looks good to me, but someone else must approve

diff --git a/util/cbfstool/cbfstool.c b/util/cbfstool/cbfstool.c
index cf89b47..54b5f65 100644
--- a/util/cbfstool/cbfstool.c
+++ b/util/cbfstool/cbfstool.c
@@ -1045,6 +1045,8 @@
    		qualifier = "read-only, ";
    	else if (region_is_modern_cbfs((const char *)current->name))
    		qualifier = "CBFS, ";
+		else if (current->flags & FMAP_AREA_PRESERVE)
+			qualifier = "preserve, ";
    	printf(" (%ssize %u, offset %u)\n", qualifier, current->size,
    			current->offset);