Change in ...coreboot[master]: mainboard/lenovo/t530: Add vboot support

[Martin Kepplinger (Code Review)]

Martin Kepplinger has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/29816 )

Change subject: mainboard/lenovo/t530: Add vboot support
......................................................................

Patch Set 5:
> Patch Set 5:
>
> so without any knowledge about coreboot's vboot: when applying your mentioned changes for the x230 and trying to build this config:
>
> CONFIG_USE_OPTION_TABLE=y
> CONFIG_VENDOR_LENOVO=y
> CONFIG_CBFS_SIZE=0x700000
> CONFIG_FMDFILE="src/mainboard/$(CONFIG_MAINBOARD_DIR)/board.fmd"
> CONFIG_VBOOT=y
> CONFIG_BOARD_LENOVO_X230=y
> # CONFIG_H8_BEEP_ON_DEATH is not set
> CONFIG_GENERIC_LINEAR_FRAMEBUFFER=y
> CONFIG_VBOOT_MEASURED_BOOT=y
> CONFIG_VBOOT_SLOTS_RW_AB=y
> CONFIG_GBB_FLAG_ENABLE_ALTERNATE_OS=y
> CONFIG_GBB_FLAG_FORCE_DEV_SWITCH_ON=y
> CONFIG_GBB_FLAG_FORCE_DEV_BOOT_LEGACY=y
> CONFIG_DEBUG_TPM=y
> CONFIG_DEFAULT_CONSOLE_LOGLEVEL_8=y
> CONFIG_NO_POST=y
> CONFIG_NVRAMCUI_SECONDARY_PAYLOAD=y
>
> coreboot doesn't build:
>
> Created CBFS (capacity = 6928344 bytes)
>     CBFS       fallback/romstage
>     CBFS       cpu_microcode_blob.bin
>     CBFS       fallback/ramstage
>     CBFS       vgaroms/seavgabios.bin
>     CBFS       config
>     CBFS       revision
>     CBFS       cmos.default
>     CBFS       vbt.bin
>     CBFS       cmos_layout.bin
>     CBFS       fallback/postcar
>     CBFS       fallback/dsdt.aml
>     CBFS       img/nvramcui
>     CBFS       fallback/payload
>     CBFS       payload_config
>     CBFS       payload_revision
>     CBFS       cpu_microcode_blob.bin
> E: Image is missing 'FW_MAIN_A' region
> E: The image will be left unmodified.
> Makefile.inc:1014: die Regel für Ziel „build/coreboot.pre“ scheiterte
>
> what am I doing wrong?

nevermind. I was using an old config or the wrong CBFS_SIZE. it builds.