Attention is currently required from: Nico Huber, Patrick Rudolph, Benjamin Doron, Paul Menzel, Arthur Heymans, Michael Niewöhner.
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51796 )
Change subject: soc/intel/common: Add InSMM.STS support
......................................................................
Patch Set 11:
(3 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/51796/comment/df0540ec_168d6e34
PS3, Line 9: Tested on HP 280 G2, SMMSTORE (v1) still works.
Good question
Ack
Commit Message:
https://review.coreboot.org/c/coreboot/+/51796/comment/8b2b7456_8c1be2a2
PS9, Line 13: - If one does not write the magic MSR `or 1`, SMMSTORE breaks.
I didn't use this document.
Ack
File src/soc/intel/common/block/smm/smihandler.c:
https://review.coreboot.org/c/coreboot/+/51796/comment/6f513648_80649505
PS9, Line 268: 0xfed30880
Various Intel documents reference this by Magic Hex value TM only. […]
Ack
--
To view, visit
https://review.coreboot.org/c/coreboot/+/51796
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia90c0e3f8ccf895bfb6d46ffe26750393dab95fb
Gerrit-Change-Number: 51796
Gerrit-PatchSet: 11
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Arthur Heymans
arthur@aheymans.xyz
Gerrit-CC: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Patrick Georgi
pgeorgi@google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Benjamin Doron
benjamin.doron00@gmail.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Comment-Date: Tue, 15 Jun 2021 07:47:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Patrick Rudolph
patrick.rudolph@9elements.com
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Arthur Heymans
arthur@aheymans.xyz
Gerrit-MessageType: comment