Nico Huber has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/48939 )
Change subject: coreinfo: Unexport COREBOOT_EXPORTS ......................................................................
coreinfo: Unexport COREBOOT_EXPORTS
coreboot's Makefile exports a lot of variables that influence make sub- processes (e.g. for Kconfig). We don't want these variables leak into sub-processes for (lib)payload builds, hence unexport them.
Change-Id: I7d65c0aa6d4550bd6600c437e838339af69496da Signed-off-by: Nico Huber nico.h@gmx.de --- M payloads/coreinfo/Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/39/48939/1
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index cd58f39..8d2f3c6 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only
+unexport $(COREBOOT_EXPORTS) + src := $(CURDIR) srctree := $(src) srck := $(src)/../../util/kconfig
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48939 )
Change subject: coreinfo: Unexport COREBOOT_EXPORTS ......................................................................
Patch Set 1: Code-Review+1
Attention is currently required from: Nico Huber. Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48939 )
Change subject: coreinfo: Unexport COREBOOT_EXPORTS ......................................................................
Patch Set 2: Code-Review+2
Nico Huber has submitted this change. ( https://review.coreboot.org/c/coreboot/+/48939 )
Change subject: coreinfo: Unexport COREBOOT_EXPORTS ......................................................................
coreinfo: Unexport COREBOOT_EXPORTS
coreboot's Makefile exports a lot of variables that influence make sub- processes (e.g. for Kconfig). We don't want these variables leak into sub-processes for (lib)payload builds, hence unexport them.
Change-Id: I7d65c0aa6d4550bd6600c437e838339af69496da Signed-off-by: Nico Huber nico.h@gmx.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/48939 Reviewed-by: Angel Pons th3fanbus@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M payloads/coreinfo/Makefile 1 file changed, 2 insertions(+), 0 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/payloads/coreinfo/Makefile b/payloads/coreinfo/Makefile index cd58f39..8d2f3c6 100644 --- a/payloads/coreinfo/Makefile +++ b/payloads/coreinfo/Makefile @@ -1,5 +1,7 @@ ## SPDX-License-Identifier: GPL-2.0-only
+unexport $(COREBOOT_EXPORTS) + src := $(CURDIR) srctree := $(src) srck := $(src)/../../util/kconfig
-
Angel Pons (Code Review) -
Nico Huber (Code Review)