Change in ...coreboot[master]: soc/intel: Remove unused pointer argument in mca_configure()

[Subrata Banik (Code Review)]

Subrata Banik has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/32616

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

soc/intel: Remove unused pointer argument in mca_configure()

This patch removes unused pointer argument in mca_configure()
function.

Change-Id: Iad3982d9db07a1f17ac39e87ff9c37956e40c258
Signed-off-by: Subrata Banik 
---
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/cannonlake/cpu.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/common/block/include/intelblocks/cpulib.h
M src/soc/intel/denverton_ns/cpu.c
M src/soc/intel/icelake/cpu.c
M src/soc/intel/skylake/cpu.c
7 files changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32616/1

diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 11d15e4..ae10244 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -76,7 +76,7 @@
    		  scope. For now every CPU clears every bank. */
    if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX) ||
        acpi_get_sleep_type() == ACPI_S5)
-		mca_configure(NULL);
+		mca_configure();

/* Set core MSRs */
    reg_script_run(core_msr_script);
diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index 8552424..d98e2f5 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -413,7 +413,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();
diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index a7f89ba..75e7112 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -300,7 +300,7 @@
    return msr.lo & 0xff;
 }

-void mca_configure(void *unused)
+void mca_configure(void)
 {
    msr_t msr;
    int i;
diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h
index 70ad253..8630fd1 100644
--- a/src/soc/intel/common/block/include/intelblocks/cpulib.h
+++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h
@@ -159,6 +159,6 @@
 uint32_t cpu_get_max_turbo_ratio(void);

/* Configure Machine Check Architecture support */
-void mca_configure(void *unused);
+void mca_configure(void);

#endif	/* SOC_INTEL_COMMON_BLOCK_CPULIB_H */
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c
index ce6df68..2a63171 100644
--- a/src/soc/intel/denverton_ns/cpu.c
+++ b/src/soc/intel/denverton_ns/cpu.c
@@ -58,7 +58,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
       of these banks are core vs package scope. For now every CPU clears
       every bank. */
-	mca_configure(NULL);
+	mca_configure();
 }

static void denverton_core_init(struct device *cpu)
diff --git a/src/soc/intel/icelake/cpu.c b/src/soc/intel/icelake/cpu.c
index b1776a0..527b989 100644
--- a/src/soc/intel/icelake/cpu.c
+++ b/src/soc/intel/icelake/cpu.c
@@ -192,7 +192,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 52b0e19..a63809b 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -428,7 +428,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();

[Patrick Rudolph (Code Review)]

Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32616 )

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

Patch Set 1: Code-Review+2

[David Guckian (Code Review)]

David Guckian has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32616 )

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

Patch Set 1: Code-Review+1

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32616 )

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

Patch Set 1: Code-Review+1

(1 comment)

https://review.coreboot.org/#/c/32616/1//COMMIT_MSG 
Commit Message:

https://review.coreboot.org/#/c/32616/1//COMMIT_MSG@9 
PS1, Line 9: This patch removes unused pointer argument in mca_configure()
           : function.
You could remove that, as it’s the same as the summary.

[Subrata Banik (Code Review)]

Hello Patrick Rudolph, Pratikkumar V Prajapati, David Guckian, Vanny E, Paul Menzel, build bot (Jenkins), Lijian Zhao, Furquan Shaikh, David Guckian,

I'd like you to reexamine a change. Please visit

https://review.coreboot.org/c/coreboot/+/32616

to look at the new patch set (#2).

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

soc/intel: Remove unused pointer argument in mca_configure()

Change-Id: Iad3982d9db07a1f17ac39e87ff9c37956e40c258
Signed-off-by: Subrata Banik 
---
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/cannonlake/cpu.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/common/block/include/intelblocks/cpulib.h
M src/soc/intel/denverton_ns/cpu.c
M src/soc/intel/icelake/cpu.c
M src/soc/intel/skylake/cpu.c
7 files changed, 7 insertions(+), 7 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/16/32616/2

[Subrata Banik (Code Review)]

Subrata Banik has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/32616 )

Change subject: soc/intel: Remove unused pointer argument in mca_configure()
......................................................................

soc/intel: Remove unused pointer argument in mca_configure()

Change-Id: Iad3982d9db07a1f17ac39e87ff9c37956e40c258
Signed-off-by: Subrata Banik 
Reviewed-on: https://review.coreboot.org/c/coreboot/+/32616
Tested-by: build bot (Jenkins) 
Reviewed-by: Patrick Rudolph 
Reviewed-by: David Guckian
Reviewed-by: Paul Menzel 
---
M src/soc/intel/apollolake/cpu.c
M src/soc/intel/cannonlake/cpu.c
M src/soc/intel/common/block/cpu/cpulib.c
M src/soc/intel/common/block/include/intelblocks/cpulib.h
M src/soc/intel/denverton_ns/cpu.c
M src/soc/intel/icelake/cpu.c
M src/soc/intel/skylake/cpu.c
7 files changed, 7 insertions(+), 7 deletions(-)

Approvals:
  build bot (Jenkins): Verified
  Paul Menzel: Looks good to me, but someone else must approve
  Patrick Rudolph: Looks good to me, approved
  David Guckian: Looks good to me, but someone else must approve

diff --git a/src/soc/intel/apollolake/cpu.c b/src/soc/intel/apollolake/cpu.c
index 651c20e..aad0f6b 100644
--- a/src/soc/intel/apollolake/cpu.c
+++ b/src/soc/intel/apollolake/cpu.c
@@ -76,7 +76,7 @@
    		  scope. For now every CPU clears every bank. */
    if (CONFIG(SOC_INTEL_COMMON_BLOCK_SGX) ||
        acpi_get_sleep_type() == ACPI_S5)
-		mca_configure(NULL);
+		mca_configure();

/* Set core MSRs */
    reg_script_run(core_msr_script);
diff --git a/src/soc/intel/cannonlake/cpu.c b/src/soc/intel/cannonlake/cpu.c
index 8552424..d98e2f5 100644
--- a/src/soc/intel/cannonlake/cpu.c
+++ b/src/soc/intel/cannonlake/cpu.c
@@ -413,7 +413,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();
diff --git a/src/soc/intel/common/block/cpu/cpulib.c b/src/soc/intel/common/block/cpu/cpulib.c
index a7f89ba..75e7112 100644
--- a/src/soc/intel/common/block/cpu/cpulib.c
+++ b/src/soc/intel/common/block/cpu/cpulib.c
@@ -300,7 +300,7 @@
    return msr.lo & 0xff;
 }

-void mca_configure(void *unused)
+void mca_configure(void)
 {
    msr_t msr;
    int i;
diff --git a/src/soc/intel/common/block/include/intelblocks/cpulib.h b/src/soc/intel/common/block/include/intelblocks/cpulib.h
index 70ad253..8630fd1 100644
--- a/src/soc/intel/common/block/include/intelblocks/cpulib.h
+++ b/src/soc/intel/common/block/include/intelblocks/cpulib.h
@@ -159,6 +159,6 @@
 uint32_t cpu_get_max_turbo_ratio(void);

/* Configure Machine Check Architecture support */
-void mca_configure(void *unused);
+void mca_configure(void);

#endif	/* SOC_INTEL_COMMON_BLOCK_CPULIB_H */
diff --git a/src/soc/intel/denverton_ns/cpu.c b/src/soc/intel/denverton_ns/cpu.c
index ce6df68..2a63171 100644
--- a/src/soc/intel/denverton_ns/cpu.c
+++ b/src/soc/intel/denverton_ns/cpu.c
@@ -58,7 +58,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
       of these banks are core vs package scope. For now every CPU clears
       every bank. */
-	mca_configure(NULL);
+	mca_configure();
 }

static void denverton_core_init(struct device *cpu)
diff --git a/src/soc/intel/icelake/cpu.c b/src/soc/intel/icelake/cpu.c
index b1776a0..527b989 100644
--- a/src/soc/intel/icelake/cpu.c
+++ b/src/soc/intel/icelake/cpu.c
@@ -192,7 +192,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();
diff --git a/src/soc/intel/skylake/cpu.c b/src/soc/intel/skylake/cpu.c
index 52b0e19..a63809b 100644
--- a/src/soc/intel/skylake/cpu.c
+++ b/src/soc/intel/skylake/cpu.c
@@ -428,7 +428,7 @@
    /* TODO(adurbin): This should only be done on a cold boot. Also, some
     * of these banks are core vs package scope. For now every CPU clears
     * every bank. */
-	mca_configure(NULL);
+	mca_configure();

/* Enable the local CPU apics */
    enable_lapic_tpr();