Change in coreboot[master]: ifdtool: refactor region_name(s) and new_layout - coreboot-gerrit

1 Sep 2017


      Bill XIE has posted comments on this change. ( https://review.coreboot.org/21315 )
Change subject: ifdtool: refactor region_name(s) and new_layout
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/#/c/21315/2/util/ifdtool/ifdtool.c
File util/ifdtool/ifdtool.c:
https://review.coreboot.org/#/c/21315/2/util/ifdtool/ifdtool.c@980
PS2, Line 980: void new_layout(const char *filename, char *image, int size,
I believe this function needs further dismantlement.
-- 
To view, visit https://review.coreboot.org/21315
To unsubscribe, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia2b92c3f835f9849a243a48c37588c2dbe7449bf
Gerrit-Change-Number: 21315
Gerrit-PatchSet: 2
Gerrit-Owner: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Bill XIE persmule@gmail.com
Gerrit-Reviewer: Nicola Corna nicola@corna.info
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 01 Sep 2017 10:00:38 +0000
Gerrit-HasComments: Yes