Attention is currently required from: Arthur Heymans, Christian Walter, David Milosevic, Julius Werner, Lean Sheng Tan, Maximilian Brune.
Martin L Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74798?usp=email )
Change subject: arch/arm64: Add EL1/EL2/EL3 support for arm64
......................................................................
Patch Set 6:
(1 comment)
File src/arch/arm64/Kconfig:
https://review.coreboot.org/c/coreboot/+/74798/comment/7316fa51_94058ae8 :
PS6, Line 30: 1 (EL1), 2 (EL2) and 3 (EL3)
Nit: Could you maybe define what these are or add why one would be chosen over another?
You can also add "If you don't know what this does, leave at the default." if you wanted.
If you don't think this is needed, feel free to Ack and close.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74798?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iae1c57f0846c8d0585384f7e54102a837e701e7e
Gerrit-Change-Number: 74798
Gerrit-PatchSet: 6
Gerrit-Owner: David Milosevic
David.Milosevic@9elements.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Christian Walter
christian.walter@9elements.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Reviewer: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-CC: Stefan Reinauer
stefan.reinauer@coreboot.org
Gerrit-CC: Yidi Lin
yidilin@google.com
Gerrit-Attention: Christian Walter
christian.walter@9elements.com
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Maximilian Brune
maximilian.brune@9elements.com
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Lean Sheng Tan
sheng.tan@9elements.com
Gerrit-Attention: David Milosevic
David.Milosevic@9elements.com
Gerrit-Comment-Date: Wed, 01 Nov 2023 16:04:18 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment