Change in coreboot[master]: mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION
Johnny Lin has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION
Tested on OCP Delta Lake. Signed-off-by: Johnny Lin johnny_lin@wiwynn.com
Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42428/1
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 739cdea..b4e88b5 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -11,6 +11,8 @@ select IPMI_KCS select IPMI_KCS_ROMSTAGE select OCP_DMI + select VPD + select VPD_SMBIOS_VERSION
config IPMI_KCS_REGISTER_SPACING int diff --git a/src/mainboard/ocp/deltalake/board.fmd b/src/mainboard/ocp/deltalake/board.fmd index a0c8dc5..9ac1331 100644 --- a/src/mainboard/ocp/deltalake/board.fmd +++ b/src/mainboard/ocp/deltalake/board.fmd @@ -7,6 +7,8 @@ SI_BIOS@0x3000000 0x1000000 { FMAP@0x0 0x800 RW_MRC_CACHE@0x1000 0x10000 - COREBOOT(CBFS)@0x11000 + RO_VPD@0x11000 0x4000 + RW_VPD@0x15000 0x4000 + COREBOOT(CBFS)@0x19000 } }
Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION ......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42428/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42428/2//COMMIT_MSG@11 PS2, Line 11: Please add the blank line above the Signed-Off-by line.
Hello build bot (Jenkins), Jonathan Zhang, insomniac,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42428
to look at the new patch set (#3).
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION
Tested on OCP Delta Lake.
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42428/3
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD_SMBIOS_VERSION ......................................................................
Patch Set 4:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42428/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42428/2//COMMIT_MSG@11 PS2, Line 11:
Please add the blank line above the Signed-Off-by line.
Done
Hello build bot (Jenkins), Jonathan Zhang, insomniac,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42428
to look at the new patch set (#10).
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD
Tested on OCP Delta Lake.
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 4 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42428/10
Hello build bot (Jenkins), Jonathan Zhang, insomniac,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42428
to look at the new patch set (#12).
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION
Tested on OCP Delta Lake.
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 5 insertions(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42428/12
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 12:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42428/12/src/mainboard/ocp/deltalak... File src/mainboard/ocp/deltalake/board.fmd:
https://review.coreboot.org/c/coreboot/+/42428/12/src/mainboard/ocp/deltalak... PS12, Line 10: RO_VPD@0x11000 0x4000 Let's group RO regions together as WP_RO, and RW regions together, similar like https://review.coreboot.org/cgit/coreboot.git/tree/src/mainboard/facebook/wa... .
Hello Philipp Deppenwiese, build bot (Jenkins), Patrick Rudolph, Jonathan Zhang, insomniac,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/42428
to look at the new patch set (#13).
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION
Tested on OCP Delta Lake.
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 13 insertions(+), 3 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/28/42428/13
Johnny Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 14:
(1 comment)
https://review.coreboot.org/c/coreboot/+/42428/12/src/mainboard/ocp/deltalak... File src/mainboard/ocp/deltalake/board.fmd:
https://review.coreboot.org/c/coreboot/+/42428/12/src/mainboard/ocp/deltalak... PS12, Line 10: RO_VPD@0x11000 0x4000
Let's group RO regions together as WP_RO, and RW regions together, similar like https://review. […]
Done
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 16: Code-Review+1
LGTM
Christian Walter has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 16: Code-Review+1
This is for VBoot RO only right? Should we rename this to vboot-ro.fmd?
Jonathan Zhang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 16:
Patch Set 16: Code-Review+1
This is for VBoot RO only right? Should we rename this to vboot-ro.fmd?
No, this is not for VBoot RO. We do not do verified boot. We group RO regions together, because later on we plan to configure write protection for all RO regions.
Philipp Deppenwiese has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
Patch Set 17: Code-Review+2
Philipp Deppenwiese has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42428 )
Change subject: mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION ......................................................................
mb/ocp/deltalake: Add VPD flash regions and select VPD and VPD_SMBIOS_VERSION
Tested on OCP Delta Lake.
Signed-off-by: Johnny Lin johnny_lin@wiwynn.com Change-Id: I1e6e2bd25cbe3b0c0547dda9e457c4d55df28388 Reviewed-on: https://review.coreboot.org/c/coreboot/+/42428 Reviewed-by: Philipp Deppenwiese zaolin.daisuki@gmail.com Reviewed-by: Jonathan Zhang jonzhang@fb.com Reviewed-by: Christian Walter christian.walter@9elements.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/mainboard/ocp/deltalake/Kconfig M src/mainboard/ocp/deltalake/board.fmd 2 files changed, 13 insertions(+), 3 deletions(-)
Approvals: build bot (Jenkins): Verified Philipp Deppenwiese: Looks good to me, approved Jonathan Zhang: Looks good to me, but someone else must approve Christian Walter: Looks good to me, but someone else must approve
diff --git a/src/mainboard/ocp/deltalake/Kconfig b/src/mainboard/ocp/deltalake/Kconfig index 698c57b..45fbcbf 100644 --- a/src/mainboard/ocp/deltalake/Kconfig +++ b/src/mainboard/ocp/deltalake/Kconfig @@ -10,6 +10,8 @@ select SUPERIO_ASPEED_AST2400 select IPMI_KCS select OCP_DMI + select VPD + select VPD_SMBIOS_VERSION
config IPMI_KCS_REGISTER_SPACING int diff --git a/src/mainboard/ocp/deltalake/board.fmd b/src/mainboard/ocp/deltalake/board.fmd index a0c8dc5..847a0a6 100644 --- a/src/mainboard/ocp/deltalake/board.fmd +++ b/src/mainboard/ocp/deltalake/board.fmd @@ -5,8 +5,16 @@ PLATFORM_DATA@0x2FE8000 0x10000 } SI_BIOS@0x3000000 0x1000000 { - FMAP@0x0 0x800 - RW_MRC_CACHE@0x1000 0x10000 - COREBOOT(CBFS)@0x11000 + MISC_RW@0x0 0x20000 { + RW_MRC_CACHE@0x0 0x10000 + RW_VPD(PRESERVE)@0x10000 0x4000 + } + WP_RO@0x20000 0xfe0000 { + RO_VPD(PRESERVE)@0x0 0x4000 + RO_SECTION@0x4000 0xfdc000 { + FMAP@0x0 0x800 + COREBOOT(CBFS)@0x800 0xfdb800 + } + } } }
-
Christian Walter (Code Review) -
Johnny Lin (Code Review)
-
Jonathan Zhang (Code Review)
-
Paul Menzel (Code Review)
-
Philipp Deppenwiese (Code Review)