Attention is currently required from: Furquan Shaikh, Nick Vaccaro, Zhuohao Lee.
Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/53908 )
Change subject: mb/google/volteer: adjust the size for RO/RW mcache
......................................................................
Patch Set 2:
(1 comment)
Patchset:
PS2:
Agree with you about the RW_PERCENTAGE. […]
In that case, I would just set the size for those specific chipsets to 8K and the default for everything else to 16K. I think defaults should always be set so they'll do the right thing for new stuff that will be added in the future, and I assume the available CAR size should only get bigger on future chipsets. Might as well make sure less people will run into trouble with this in the future.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/53908
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If9552bc9fa5d36b1ca662c9da030ae7b137b60a8
Gerrit-Change-Number: 53908
Gerrit-PatchSet: 2
Gerrit-Owner: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Reviewer: Nick Vaccaro
nvaccaro@google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Furquan Shaikh
furquan@google.com
Gerrit-Attention: Nick Vaccaro
nvaccaro@chromium.org
Gerrit-Attention: Zhuohao Lee
zhuohao@chromium.org
Gerrit-Comment-Date: Fri, 07 May 2021 23:56:01 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Gerrit-MessageType: comment