Attention is currently required from: Felix Singer, Karthik Ramasubramanian, Martin L Roth, Raul Rangel.
Jon Murphy has posted comments on this change by Jon Murphy. ( https://review.coreboot.org/c/coreboot/+/85275?usp=email )
Change subject: util/crossgcc: Add libstdcxx target ......................................................................
Patch Set 14:
(1 comment)
Patchset:
PS5:
We can't support everything. […]
My patch adds 39 lines, so that's not really a fair comment.
nds32le was added in support of the ChromeOS EC since we have EC variants that use that architecture.
I can't speak to why the submodule for the EC was pulled in in the first place, that doesn't seem germane to this review.
It feels like a lot of misplaced baggage is being brought into the review of this change.
There's no expectation for the coreboot community to maintain anything here, it's enabling the build of another library, and it's providing functionality to a toolchain which coreboot has already chosen to support.
Having support for building another library which is inherently supported by the GCC distribution that we're already pulling doesn't seem like a bad thing. It's added in a way that doesn't affect anything else.
This patch is calling configure and make on a tarball that we're already pulling and extracting.
-
Jon Murphy (Code Review)