Change in coreboot[master]: pciexp_device: Rewrite LTR configuration - coreboot-gerrit

12 Mar 2021


      Attention is currently required from: Nico Huber, Furquan Shaikh, Michael Niewöhner, Kyösti Mälkki, Patrick Rudolph, Aaron Durbin.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/51328 )
Change subject: pciexp_device: Rewrite LTR configuration
......................................................................
Patch Set 2:
(1 comment)
File src/device/pciexp_device.c:
https://review.coreboot.org/c/coreboot/+/51328/comment/2471b950_9900ddeb 
PS1, Line 130: _
...
It's not about static functions. I used the _ prefix here when I needed a […]
Not a big deal, I just know that sometimes I miss the `_` prefix and get confused for a sec.
-- 
To view, visit https://review.coreboot.org/c/coreboot/+/51328
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings

Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2c5b8658f1fc8cec15e8b0824464c6fc9bee7e0e
Gerrit-Change-Number: 51328
Gerrit-PatchSet: 2
Gerrit-Owner: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Aaron Durbin adurbin@chromium.org
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner foss@mniewoehner.de
Gerrit-Reviewer: Patrick Rudolph siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-CC: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Attention: Nico Huber nico.h@gmx.de
Gerrit-Attention: Furquan Shaikh furquan@google.com
Gerrit-Attention: Michael Niewöhner foss@mniewoehner.de
Gerrit-Attention: Kyösti Mälkki kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph siro@das-labor.org
Gerrit-Attention: Aaron Durbin adurbin@chromium.org
Gerrit-Comment-Date: Fri, 12 Mar 2021 23:48:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber nico.h@gmx.de
Comment-In-Reply-To: Tim Wawrzynczak twawrzynczak@chromium.org
Gerrit-MessageType: comment