HAOUAS Elyes has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/41996 )
Change subject: drivers/intel/gma/intel_ddi.c: Clean up ......................................................................
drivers/intel/gma/intel_ddi.c: Clean up
Remove unused includes.
Change-Id: I91dd92b54822dd0d10051ccd600ce787860c8ff6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/intel_ddi.c 1 file changed, 0 insertions(+), 7 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41996/1
diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index 3893664..24bc162 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -1,14 +1,7 @@ /* SPDX-License-Identifier: MIT */
#include <types.h> -#include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> -#include <acpi/acpi.h> -#include <device/pci.h> -#include <ec/google/chromeec/ec.h> -#include <cpu/x86/tsc.h> -#include <edid.h> #include <drivers/intel/gma/i915.h>
/* HDMI/DVI modes ignore everything but the last 2 items. So we share
Hello build bot (Jenkins), Angel Pons, Patrick Rudolph,
I'd like you to reexamine a change. Please visit
https://review.coreboot.org/c/coreboot/+/41996
to look at the new patch set (#6).
Change subject: drivers/intel/gma/intel_ddi.c: Clean up ......................................................................
drivers/intel/gma/intel_ddi.c: Clean up
Remove unused includes.
Change-Id: I91dd92b54822dd0d10051ccd600ce787860c8ff6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr --- M src/drivers/intel/gma/intel_ddi.c 1 file changed, 0 insertions(+), 8 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/96/41996/6
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41996 )
Change subject: drivers/intel/gma/intel_ddi.c: Clean up ......................................................................
Patch Set 6: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/41996 )
Change subject: drivers/intel/gma/intel_ddi.c: Clean up ......................................................................
drivers/intel/gma/intel_ddi.c: Clean up
Remove unused includes.
Change-Id: I91dd92b54822dd0d10051ccd600ce787860c8ff6 Signed-off-by: Elyes HAOUAS ehaouas@noos.fr Reviewed-on: https://review.coreboot.org/c/coreboot/+/41996 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Angel Pons th3fanbus@gmail.com --- M src/drivers/intel/gma/intel_ddi.c 1 file changed, 0 insertions(+), 8 deletions(-)
Approvals: build bot (Jenkins): Verified Angel Pons: Looks good to me, approved
diff --git a/src/drivers/intel/gma/intel_ddi.c b/src/drivers/intel/gma/intel_ddi.c index a04789b..24bc162 100644 --- a/src/drivers/intel/gma/intel_ddi.c +++ b/src/drivers/intel/gma/intel_ddi.c @@ -1,15 +1,7 @@ /* SPDX-License-Identifier: MIT */
#include <types.h> -#include <device/device.h> -#include <device/pci_def.h> #include <console/console.h> -#include <acpi/acpi.h> -#include <device/pci.h> -#include <ec/google/chromeec/ec.h> -#include <cpu/x86/tsc.h> -#include <cpu/x86/msr.h> -#include <edid.h> #include <drivers/intel/gma/i915.h>
/* HDMI/DVI modes ignore everything but the last 2 items. So we share