Attention is currently required from: Martin Roth, Julius Werner, mturney mturney. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49768 )
Change subject: sc7280: cpucp loading changes ......................................................................
Patch Set 22:
(42 comments)
File src/soc/qualcomm/sc7280/cpucp_load_reset.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/a01304f1_47560f27 PS22, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/87151249_4ec01929 PS22, Line 15: uint32_t val = read32(EPSSTOP_SECURE_ACCESS_OVERRIDE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/4ee67c09_ea6fd39c PS22, Line 16: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/7babdae0_fa180876 PS22, Line 16: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/3df07def_88e7effd PS22, Line 18: /* allow NS access to EPSS memory*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/b3b3e78f_755e8af4 PS22, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/940421be_afd97082 PS22, Line 19: write32(EPSSTOP_SECURE_ACCESS_OVERRIDE, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/a014993f_69bb1dd4 PS22, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/09ee4bf5_6e075421 PS22, Line 21: val = read32(EPSSFAST_EPSS_MUC_CLK_CTRL); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/efa52201_a622888b PS22, Line 22: val |= 0x1; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/1ffe0a15_ef96dde3 PS22, Line 22: val |= 0x1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/7611c067_bb361b5d PS22, Line 24: /* Enable subsystem clock. Required for CPUCP PDMEM access*/ code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/5597ee64_8c495f32 PS22, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/c0237068_95189957 PS22, Line 25: write32(EPSSFAST_EPSS_MUC_CLK_CTRL, val); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/9fa8ee67_3e92b971 PS22, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/7278f405_43ac8fd0 PS22, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/49f5ebd4_88542c11 PS22, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); space required before the open parenthesis '('
https://review.coreboot.org/c/coreboot/+/49768/comment/5772be32_dc994ed4 PS22, Line 27: while((read32(EPSSFAST_EPSS_MUC_CLK_CTRL) & 0x1) != 0x1); trailing statements should be on next line
https://review.coreboot.org/c/coreboot/+/49768/comment/04110428_fcfbe75f PS22, Line 32: bool cpucp_fw_entry; code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/fb97117a_70684f9c PS22, Line 32: bool cpucp_fw_entry; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/bff29ca8_5471c936 PS22, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/56bb9634_985c3de3 PS22, Line 33: printk(BIOS_DEBUG, "\nSOC:CPUCP image loading.\n"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/367081ab_71bbbe2d PS22, Line 35: struct prog cpucp_fw_prog = code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/bb41b759_659109bd PS22, Line 35: struct prog cpucp_fw_prog = please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/f184d7f2_a53a5e74 PS22, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/0523bdf8_4f0b59d5 PS22, Line 36: PROG_INIT(PROG_PAYLOAD, CONFIG_CBFS_PREFIX "/cpucp"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/e3613a12_00dc2cd5 PS22, Line 38: cpucp_prepare(); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/42cded7e_56cc2f8e PS22, Line 38: cpucp_prepare(); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/0de971ae_7bee4889 PS22, Line 40: if (prog_locate(&cpucp_fw_prog)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/a40ca84b_5ac51cdf PS22, Line 40: if (prog_locate(&cpucp_fw_prog)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/1421d2ec_92b65c99 PS22, Line 41: die("SOC imagpe: CPUCP_FW not found"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/1341483d_164cb871 PS22, Line 41: die("SOC imagpe: CPUCP_FW not found"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/c38b8ede_60b68b8e PS22, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/a867e334_b8d37acd PS22, Line 43: cpucp_fw_entry = selfload(&cpucp_fw_prog); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/7dc7b2b8_ef338b28 PS22, Line 44: if (!cpucp_fw_entry) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/036041d9_747c59d3 PS22, Line 44: if (!cpucp_fw_entry) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/821923d7_5126ec2f PS22, Line 45: die("SOC image: CPUCP load failed"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/17798eec_51b5a1eb PS22, Line 45: die("SOC image: CPUCP load failed"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/49768/comment/89b0487c_9e42f555 PS22, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/3d2b9e80_5d744dac PS22, Line 49: printk(BIOS_DEBUG, "\nSOC:CPUCP image loaded successfully.\n"); please, no spaces at the start of a line
File src/soc/qualcomm/sc7280/soc.c:
https://review.coreboot.org/c/coreboot/+/49768/comment/987d951f_c5ee04b7 PS22, Line 20: REGION_SIZE(dram_cpucp) / KiB); code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/49768/comment/a76b79e2_eab5576b PS22, Line 20: REGION_SIZE(dram_cpucp) / KiB); please, no spaces at the start of a line
-
build bot (Jenkins) (Code Review)