Paul Menzel has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/42197 )
Change subject: soc/intel/skylake: Use unit macros KiB and MiB ......................................................................
soc/intel/skylake: Use unit macros KiB and MiB
Unify the file with the Cannon Lake version `src/soc/intel/cannonlake/smmrelocate.c`.
Change-Id: Id4815836e93081b61f4c09b8b3ed81199d3ff409 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de --- M src/soc/intel/skylake/smmrelocate.c 1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/97/42197/1
diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c index cb83d61..476ab93 100644 --- a/src/soc/intel/skylake/smmrelocate.c +++ b/src/soc/intel/skylake/smmrelocate.c @@ -150,7 +150,7 @@ uintptr_t tseg_base; size_t tseg_size; /* All range registers are aligned to 4KiB */ - const u32 rmask = ~((1 << 12) - 1); + const u32 rmask = ~(4 * KiB - 1);
smm_region(&tseg_base, &tseg_size); smm_subregion(SMM_SUBREGION_CHIPSET, ¶ms->ied_base, ¶ms->ied_size); @@ -181,7 +181,7 @@ memcpy(ied_base, &ied, sizeof(ied));
/* Zero out 32KiB at IEDBASE + 1MiB */ - memset(ied_base + (1 << 20), 0, (32 << 10)); + memset(ied_base + 1 * MiB, 0, 32 * KiB); }
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42197 )
Change subject: soc/intel/skylake: Use unit macros KiB and MiB ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/42197 )
Change subject: soc/intel/skylake: Use unit macros KiB and MiB ......................................................................
soc/intel/skylake: Use unit macros KiB and MiB
Unify the file with the Cannon Lake version `src/soc/intel/cannonlake/smmrelocate.c`.
Change-Id: Id4815836e93081b61f4c09b8b3ed81199d3ff409 Signed-off-by: Paul Menzel pmenzel@molgen.mpg.de Reviewed-on: https://review.coreboot.org/c/coreboot/+/42197 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Patrick Georgi pgeorgi@google.com --- M src/soc/intel/skylake/smmrelocate.c 1 file changed, 2 insertions(+), 2 deletions(-)
Approvals: build bot (Jenkins): Verified Patrick Georgi: Looks good to me, approved
diff --git a/src/soc/intel/skylake/smmrelocate.c b/src/soc/intel/skylake/smmrelocate.c index cb83d61..476ab93 100644 --- a/src/soc/intel/skylake/smmrelocate.c +++ b/src/soc/intel/skylake/smmrelocate.c @@ -150,7 +150,7 @@ uintptr_t tseg_base; size_t tseg_size; /* All range registers are aligned to 4KiB */ - const u32 rmask = ~((1 << 12) - 1); + const u32 rmask = ~(4 * KiB - 1);
smm_region(&tseg_base, &tseg_size); smm_subregion(SMM_SUBREGION_CHIPSET, ¶ms->ied_base, ¶ms->ied_size); @@ -181,7 +181,7 @@ memcpy(ied_base, &ied, sizeof(ied));
/* Zero out 32KiB at IEDBASE + 1MiB */ - memset(ied_base + (1 << 20), 0, (32 << 10)); + memset(ied_base + 1 * MiB, 0, 32 * KiB); }
void smm_info(uintptr_t *perm_smbase, size_t *perm_smsize,
-
Patrick Georgi (Code Review) -
Paul Menzel (Code Review)