Change in coreboot[master]: cpu/intel/model_2065x: Drop unused c-state options

[Angel Pons (Code Review)]

Angel Pons has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/49091 )

Change subject: cpu/intel/model_2065x: Drop unused c-state options
......................................................................

cpu/intel/model_2065x: Drop unused c-state options

None of the mainboards sets any value for these options, so they are
always zero. Drop them and use hardcoded constants instead. Note that
the function exits early because the devicetrees do not contain any
device with the magic SpeedStep APIC ID.

Untested due to lack of hardware, but the behavior remains unchanged.

Change-Id: I2b20ec6612f6c3307ac19f2d22fa3a4744d9d441
Signed-off-by: Angel Pons 
---
M src/cpu/intel/model_2065x/acpi.c
M src/cpu/intel/model_2065x/chip.h
2 files changed, 2 insertions(+), 11 deletions(-)

git pull ssh://review.coreboot.org:29418/coreboot refs/changes/91/49091/1

diff --git a/src/cpu/intel/model_2065x/acpi.c b/src/cpu/intel/model_2065x/acpi.c
index 2d483ca..5591d7e 100644
--- a/src/cpu/intel/model_2065x/acpi.c
+++ b/src/cpu/intel/model_2065x/acpi.c
@@ -93,14 +93,12 @@
    acpigen_write_len_f();		/* PkgLength */
    acpigen_emit_namestring("PWRS");
    acpigen_emit_byte(0xa4);	/* ReturnOp */
-	generate_cstate_entries(cpu->cstates, conf->c1_acpower,
-				conf->c2_acpower, conf->c3_acpower);
+	generate_cstate_entries(cpu->cstates, 0, 0, 0);	/* TODO: Use non-zero values? */
    acpigen_pop_len();

/* Else on battery power */
    acpigen_emit_byte(0xa4);	/* ReturnOp */
-	generate_cstate_entries(cpu->cstates, conf->c1_battery,
-				conf->c2_battery, conf->c3_battery);
+	generate_cstate_entries(cpu->cstates, 0, 0, 0);	/* TODO: Use non-zero values? */
    acpigen_pop_len();
 }

diff --git a/src/cpu/intel/model_2065x/chip.h b/src/cpu/intel/model_2065x/chip.h
index d9b1057..1f07fb7 100644
--- a/src/cpu/intel/model_2065x/chip.h
+++ b/src/cpu/intel/model_2065x/chip.h
@@ -4,13 +4,6 @@
 #define SPEEDSTEP_APIC_MAGIC 0xACAC

struct cpu_intel_model_2065x_config {
-	int c1_battery;		/* ACPI C1 on Battery Power */
-	int c2_battery;		/* ACPI C2 on Battery Power */
-	int c3_battery;		/* ACPI C3 on Battery Power */
-
-	int c1_acpower;		/* ACPI C1 on AC Power */
-	int c2_acpower;		/* ACPI C2 on AC Power */
-	int c3_acpower;		/* ACPI C3 on AC Power */

int tcc_offset;		/* TCC Activation Offset */
 };

[Paul Menzel (Code Review)]

Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/49091 )

Change subject: cpu/intel/model_2065x: Drop unused c-state options
......................................................................

Patch Set 1:

This change is ready for review.

[Angel Pons (Code Review)]

Angel Pons has abandoned this change. ( https://review.coreboot.org/c/coreboot/+/49091 )

Change subject: cpu/intel/model_2065x: Drop unused c-state options
......................................................................

Abandoned

Superseded