Attention is currently required from: Patrick Rudolph, Paul Menzel.
Kyösti Mälkki has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78194?usp=email )
Change subject: cpu/intel/model_206ax: Only use supported C-states
......................................................................
Patch Set 2:
(2 comments)
File src/cpu/intel/model_206ax/acpi.c:
https://review.coreboot.org/c/coreboot/+/78194/comment/c8dabc74_212ad8dd :
PS2, Line 106: acpi_cstate_map[count].ctype = i + 1;
I don't see the .ctype field filled anymore.
https://review.coreboot.org/c/coreboot/+/78194/comment/28e027ba_48e9fad3 :
PS2, Line 97: uint8_t h, l;
state, substate ? If you changed the previous function on Felix's request.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78194?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Iaaee050e0ce3c29c12e97f5819a29f485a7946c2
Gerrit-Change-Number: 78194
Gerrit-PatchSet: 2
Gerrit-Owner: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Reviewer: Paul Menzel
paulepanter@mailbox.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Attention: Patrick Rudolph
patrick.rudolph@9elements.com
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Comment-Date: Tue, 03 Oct 2023 10:12:22 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment