Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46249 )
Change subject: mb/clevo/l140cu: rework memcfg ......................................................................
Patch Set 2:
(8 comments)
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... File src/mainboard/clevo/cml-u/variants/l140cu/romstage.c:
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 7: /* Parameters required to access SPD for CH0D0/CH0D1/CH1D0/CH1D1. */
Please drop this comment
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 10: .spd_spec = {.spd_index = 0},
reading my previous comment again, don't remove the index = 0. it's intentionally zero.
whatever I was thinking (probably I was *not* thinking at all)... just ignore my comment o.O
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 20: DRAM
lol. no.
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 25: These will typically be the following : * values for Cannon Lake : { 80, 40, 40, 40, 30 }
Drop these
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 31: Indicates whether memory is interleaved. : * Set to 1 for an interleaved design, : * set to 0 for non-interleaved design.
😄
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 38: * VREF_CA configuration. : * Set to 0 VREF_CA goes to both CH_A and CH_B, : * set to 1 VREF_CA goes to CH_A and VREF_DQ_A goes to CH_B, : * set to 2 VREF_CA goes to CH_A and VREF_DQ_B goes to CH_B.
Replace this with something that explains the chosen value: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 45: /* Early Command Training */
Same here: https://review.coreboot. […]
Done
https://review.coreboot.org/c/coreboot/+/46249/1/src/mainboard/clevo/cml-u/v... PS1, Line 46: .ect = 0, already initialized to zero. dropped
-
Michael Niewöhner (Code Review)