Attention is currently required from: Jakub Czapiga, Caveh Jalali, Julius Werner, Boris Mittelberg.
Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69762 )
Change subject: vboot: Fix hash digest size, padding and comparison
......................................................................
Patch Set 3:
(2 comments)
File src/ec/google/chromeec/vboot_storage.c:
https://review.coreboot.org/c/coreboot/+/69762/comment/b1648d64_42dc3fbc
PS2, Line 21: memset(data, 0, sizeof(data));
There is a slot number check and max data size check. […]
With
```
struct ec_params_vstore_write req = {
.slot = slot,
};
```
I think the unspecified field `.data` will be zero.
https://review.coreboot.org/c/coreboot/+/69762/comment/e509ad7b_8980e755
PS2, Line 50: assert(digest_size == EC_VSTORE_SLOT_SIZE);
It has to stay. […]
Right.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/69762
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: If6d46e0b58dbca86af56221b7ff2606ab2d1799a
Gerrit-Change-Number: 69762
Gerrit-PatchSet: 3
Gerrit-Owner: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Boris Mittelberg
bmbm@google.com
Gerrit-Reviewer: Caveh Jalali
caveh@chromium.org
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Caveh Jalali
caveh@chromium.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Boris Mittelberg
bmbm@google.com
Gerrit-Comment-Date: Mon, 21 Nov 2022 13:25:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Jakub Czapiga
jacz@semihalf.com
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Gerrit-MessageType: comment