Change in coreboot[master]: soc/intel/cannonlake: Hook up DPTF device to devicetree

[Felix Singer (Code Review)]

Attention is currently required from: Tim Crawford, Nico Huber, Patrick Rudolph, Jeremy Soller, Christian Walter, Tim Wawrzynczak, Michael Niewöhner.
 Felix Singer has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/59887 )

Change subject: soc/intel/cannonlake: Hook up DPTF device to devicetree
......................................................................

Patch Set 4:

(3 comments)

File src/mainboard/google/hatch/variants/baseboard/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/59887/comment/2928dde3_03322c50 
PS4, Line 204: 		device pci 04.0 on  end # SA Thermal device
> I would prefer separate changes for devices that had it `off` by accident. […]

In any case the behavior is changed in some way. I prefer setting the devicetree state according to the value of Device4Enable. This is how I did it in all my other patches during the move from options to devicetree states.

File src/mainboard/system76/bonw14/devicetree.cb:

https://review.coreboot.org/c/coreboot/+/59887/comment/e4b05a24_40cf2ee1 
PS4, Line 72: 		device pci 04.0 off end # SA Thermal device
> Do you mean the intention was to enable it?

I think he means configuring the `Device4Enable` setting. All other System76 boards have it.

File src/soc/intel/cannonlake/fsp_params.c:

https://review.coreboot.org/c/coreboot/+/59887/comment/a22ea773_4873e847 
PS4, Line 592: DSP
> I assume this is just wrongly named in the header file??

Yes, seems like it was introduced with a wrong name.