Attention is currently required from: Tarun Tuli, Martin L Roth, Subrata Banik, Andrey Petrov.
build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69757 )
Change subject: [RFC] Pull ligfxinit in romstage ......................................................................
Patch Set 1:
(18 comments)
File src/drivers/intel/fsp2_0/memory_init.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/2a0beed9_0b097027 PS1, Line 53: struct cpuid_result cp = cpuid_ext(1, 0); please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/f3a13bc6_98ad0937 PS1, Line 56: if (!(cp.ecx & (1 << 6))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/d269e6ee_49941f55 PS1, Line 56: if (!(cp.ecx & (1 << 6))) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/5aefd118_8da2379d PS1, Line 57: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/4d8b946e_1da0068d PS1, Line 57: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/dc7ade44_bb69f993 PS1, Line 60: if (!(read32((void *)0xfed30010) & 1)) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/2993709e_6a6159c8 PS1, Line 60: if (!(read32((void *)0xfed30010) & 1)) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/d102fcfb_101eca98 PS1, Line 61: return; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/1cffb928_6c37f20b PS1, Line 61: return; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/4be29b68_83ab77f0 PS1, Line 64: while (!(read8((void *)0xfed40000) & (1 << 7))) please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/cf938435_1c6c7c40 PS1, Line 64: while (!(read8((void *)0xfed40000) & (1 << 7))) suspect code indent for conditional statements (7, 15)
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/bb3b70b6_d764076b PS1, Line 65: ; code indent should use tabs where possible
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/16328cf4_79b8f6a0 PS1, Line 65: ; please, no spaces at the start of a line
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/4eaa392f_5de2221d PS1, Line 288: printk(BIOS_DEBUG, "J2M: Initalizing backlight\n"); 'Initalizing' may be misspelled - perhaps 'Initializing'?
File src/soc/intel/common/block/graphics/graphics.c:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/137d0cbf_7c85b25e PS1, Line 43: /* graphics_soc_panel_init(dev); */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/5dc3a0b6_5979e68c PS1, Line 72: /* int lightup_ok; */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/e4140ad3_c1596564 PS1, Line 73: /* gma_gfxinit(&lightup_ok); */ please, no space before tabs
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-163987): https://review.coreboot.org/c/coreboot/+/69757/comment/4508fbb1_00b7a41a PS1, Line 74: /* gfx_set_init_done(lightup_ok); */ please, no space before tabs
-
build bot (Jenkins) (Code Review)