Marshall Dawson has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/38470 )
Change subject: drivers/smmstore: Clarify Kconfig cbfs wording ......................................................................
drivers/smmstore: Clarify Kconfig cbfs wording
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ibb37c2d99c1a95b1d37bec784c98e636da4836d9 --- M src/drivers/smmstore/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/70/38470/1
diff --git a/src/drivers/smmstore/Kconfig b/src/drivers/smmstore/Kconfig index 668f876..333f5e1d 100644 --- a/src/drivers/smmstore/Kconfig +++ b/src/drivers/smmstore/Kconfig @@ -21,7 +21,7 @@ bool default n help - Select this if you want to the SMMSTORE region in a + Select this if you want to add an SMMSTORE region to a cbfsfile in a cbfs FMAP region
if SMMSTORE
Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38470 )
Change subject: drivers/smmstore: Clarify Kconfig cbfs wording ......................................................................
Patch Set 1: Code-Review+2
That grammar abuse hurts :D
Matt DeVillier has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38470 )
Change subject: drivers/smmstore: Clarify Kconfig cbfs wording ......................................................................
Patch Set 1: Code-Review+2
Patrick Georgi has submitted this change. ( https://review.coreboot.org/c/coreboot/+/38470 )
Change subject: drivers/smmstore: Clarify Kconfig cbfs wording ......................................................................
drivers/smmstore: Clarify Kconfig cbfs wording
Signed-off-by: Marshall Dawson marshalldawson3rd@gmail.com Change-Id: Ibb37c2d99c1a95b1d37bec784c98e636da4836d9 Reviewed-on: https://review.coreboot.org/c/coreboot/+/38470 Reviewed-by: Angel Pons th3fanbus@gmail.com Reviewed-by: Matt DeVillier matt.devillier@gmail.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/drivers/smmstore/Kconfig 1 file changed, 1 insertion(+), 1 deletion(-)
Approvals: build bot (Jenkins): Verified Matt DeVillier: Looks good to me, approved Angel Pons: Looks good to me, approved
diff --git a/src/drivers/smmstore/Kconfig b/src/drivers/smmstore/Kconfig index 668f876..333f5e1d 100644 --- a/src/drivers/smmstore/Kconfig +++ b/src/drivers/smmstore/Kconfig @@ -21,7 +21,7 @@ bool default n help - Select this if you want to the SMMSTORE region in a + Select this if you want to add an SMMSTORE region to a cbfsfile in a cbfs FMAP region
if SMMSTORE
9elements QA has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/38470 )
Change subject: drivers/smmstore: Clarify Kconfig cbfs wording ......................................................................
Patch Set 2:
Automatic boot test returned (PASS/FAIL/TOTAL): 3/0/3 Emulation targets: EMULATION_QEMU_X86_Q35 using payload TianoCore : SUCCESS : https://lava.9esec.io/r/198 EMULATION_QEMU_X86_Q35 using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/197 EMULATION_QEMU_X86_I440FX using payload SeaBIOS : SUCCESS : https://lava.9esec.io/r/196
Please note: This test is under development and might not be accurate at all!
-
9elements QA (Code Review) -
Angel Pons (Code Review)
-
Marshall Dawson (Code Review)
-
Matt DeVillier (Code Review)
-
Patrick Georgi (Code Review)