Attention is currently required from: Arthur Heymans, Julius Werner, Paul Menzel, Yu-Ping Wu.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/78798?usp=email )
Change subject: commonlib: Add GCD function
......................................................................
Patch Set 5:
(2 comments)
File src/commonlib/bsd/gcd.c:
https://review.coreboot.org/c/coreboot/+/78798/comment/e50b1e54_2535955a :
PS2, Line 10: if (a == 0 || b == 0)
`gcd(0, 123)` is mathematically well-defined. […]
Done
File tests/commonlib/bsd/gcd-test.c:
https://review.coreboot.org/c/coreboot/+/78798/comment/78fbb05c_5309f40a :
PS4, Line 7: {
Add some edge cases here such as […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/78798?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I21819cda4299b3809b8ca7a95cbdc6a87e4b3481
Gerrit-Change-Number: 78798
Gerrit-PatchSet: 5
Gerrit-Owner: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Julius Werner
jwerner@chromium.org
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Julius Werner
jwerner@chromium.org
Gerrit-Attention: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Comment-Date: Thu, 02 Nov 2023 09:39:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Julius Werner
jwerner@chromium.org
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com
Comment-In-Reply-To: Yidi Lin
yidilin@google.com
Gerrit-MessageType: comment