Attention is currently required from: Hung-Te Lin, Yidi Lin, Yu-Ping Wu.
Jarried Lin has posted comments on this change by Jarried Lin. ( https://review.coreboot.org/c/coreboot/+/85799?usp=email )
Change subject: soc/mediatek/mt8196: Delay 0.5ms after enabling pmif_spmi_enable_swinf
......................................................................
Patch Set 4:
(1 comment)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85799/comment/fd6d4eb4_01063359?usp... :
PS4, Line 7: pmif_spmi_enable_swinf
In the other comment I was thinking about plain text. […]
Hi Yuping,
Sorry, I'm not quite sure what this comment is asking to modify. If you are asking about the meaning of 'swint', it indeed stands for SW interface.
Or do you want to modify the commit subject to:
Delay 0.5ms after enabling pmif spmi enable SW interface?
thanks
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85799?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I63df384061e4ed2629238f1843decd18d1ad1ac4
Gerrit-Change-Number: 85799
Gerrit-PatchSet: 4
Gerrit-Owner: Jarried Lin
jarried.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Yidi Lin
yidilin@google.com
Gerrit-Reviewer: Yu-Ping Wu
yupingso@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Hope Wang
hope.wang@mediatek.corp-partner.google.com
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Yu-Ping Wu
yupingso@google.com
Gerrit-Attention: Yidi Lin
yidilin@google.com
Gerrit-Comment-Date: Tue, 07 Jan 2025 03:45:39 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Yu-Ping Wu
yupingso@google.com