Aaron Durbin (adurbin@chromium.org) just uploaded a new patch set to gerrit, which you can find at http://review.coreboot.org/10279
-gerrit
commit a5ad72d19942a9717253ae4815a54d897ab9b0e2 Author: Aaron Durbin adurbin@chromium.org Date: Thu May 21 14:54:18 2015 -0500
consoles: remove unused infrastructure
The __console attribute as well as linker binding was dropped at some point. Kill of the dead code and infrastructure.
Change-Id: I15e1fb4468fffe2e148ec9ac8539dfd958551807 Signed-off-by: Aaron Durbin adurbin@chromium.org --- src/console/uart_wrapper.c | 28 ---------------------------- src/include/console/console.h | 6 ------ src/lib/ramstage.ld | 4 ---- 3 files changed, 38 deletions(-)
diff --git a/src/console/uart_wrapper.c b/src/console/uart_wrapper.c deleted file mode 100644 index 0454cfc..0000000 --- a/src/console/uart_wrapper.c +++ /dev/null @@ -1,28 +0,0 @@ -/* - * This file is part of the coreboot project. - * Copyright 2014 Google Inc. - * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; version 2 of the License. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the - * GNU General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA - */ - -#include <console/console.h> -#include <console/uart.h> - -static const struct console_driver uart_console __console = { - .init = uart_init, - .tx_byte = uart_tx_byte, - .tx_flush = uart_tx_flush, - .rx_byte = uart_rx_byte, - .tst_byte = uart_can_rx_byte, -}; diff --git a/src/include/console/console.h b/src/include/console/console.h index 65e65bb..d25c792 100644 --- a/src/include/console/console.h +++ b/src/include/console/console.h @@ -34,12 +34,6 @@ struct console_driver { int (*tst_byte)(void); };
-#define __console __attribute__((used, __section__ (".rodata.console_drivers"))) - -/* Defined by the linker... */ -extern struct console_driver console_drivers[]; -extern struct console_driver econsole_drivers[]; - void post_code(u8 value); #if CONFIG_CMOS_POST_EXTRA void post_log_extra(u32 value); diff --git a/src/lib/ramstage.ld b/src/lib/ramstage.ld index f12653e..744f277 100644 --- a/src/lib/ramstage.ld +++ b/src/lib/ramstage.ld @@ -53,10 +53,6 @@ /* If any changes are made to the driver start/symbols or the * section names the equivalent changes need to made to * rmodule.ld. */ - console_drivers = .; - KEEP(*(.rodata.console_drivers)); - econsole_drivers = . ; - . = ALIGN(8); pci_drivers = . ; KEEP(*(.rodata.pci_driver)); epci_drivers = . ;